Re: [Vxl-maintainers] test failure of vil/tests/vil_test_all test_file_format_read

[Sean M. <se...@ro...>]

On Thu, 22 May 2014 09:57:10 -0400, Gehua Yang said:

>By the way, I also made the same fix for vil1 test.
>
>While the disabling of line conversion on .pbm file fixed the tests on
>my Windows machine, it seems the two Windows machines on the dashboard
>still gave the same error:
>
>eastmodelsoft.com
>http://open.cdash.org/viewTest.php?onlyfailed&buildid=3338824
>
>and
>NSK1200016973I.GE
>http://open.cdash.org/viewTest.php?onlyfailed&buildid=3339090
>
>Could someone who have access to these two machines take a look into
>this issue?

If I may say, the wiser course, IMNSHO, :) is to first attack the compiler warnings.  Warnings are there to help find bugs.  For all we know, the cause of that test failure is already being pointed to by a helpful compiler.  Modern compilers are giving really great warnings these days.  Here's two examples:

(1) In contrib/brl/bseg/bvxm/grid/bvxm_voxel_storage_slab_mem.txx

 #ifndef bvxm_voxel_storage_slab_mem_txx_
 #define bvxm_voxel_stroage_slab_mem_txx_

See the typo?  No?  The compiler did:

warning: 'bvxm_voxel_storage_slab_mem_txx_' is used as a header guard here, followed by #define of a different macro [-Wheader-guard]

(2) In contrib/rpl/rgrl/tests/test_transformation.cxx

 double det = vnl_determinant(R);
 if (! det == 1.0 )

test_transformation.cxx:302:9: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses]

Very likely we want "if (! ( det == 1.0 ) )".


But these helpful things can't be seen because the dashboard is such a God awful mess. :(

Instead of just ranting :), I've just fixed a bunch of the low-hanging fruit.  Patches attached.  Please review carefully as I do not really know the codebase at all.

Cheers,

-- 
____________________________________________________________
Sean McBride, B. Eng                 se...@ro...
Rogue Research                        www.rogue-research.com 
Mac Software Developer              Montréal, Québec, Canada