Re: [Vxl-users] vsl_b_read reading vnl_sparse_matrix

[Ian S. <sc...@im...>]

Fix committed.

Many thanks,
Ian.

On 01/03/2013 14:03, Luciano Lorenti wrote:
> Ian, the matrix was 10000 x 10000
>
> 2013/3/1 Ian Scott <sc...@im...>:
>> Luciano,
>>
>> Thanks for the bug report.
>>
>> So that I can put in a regression test, could you tell me what size of
>> sparse matrix triggered the bug?
>>
>> Thanks,
>> Ian.
>>
>>
>> On 28/02/2013 19:56, Luciano Lorenti wrote:
>>>
>>> I was having trouble reading a vnl_sparse_matrix stored in a file.
>>> The numbers of rows and columns recovered from the file never matched
>>> with the original one.
>>> I realized that in
>>>
>>> template<class T>
>>> void vsl_b_write(vsl_b_ostream & os, const vnl_sparse_matrix<T> & p) {
>>> ...
>>>     vsl_b_write(os, v.rows());
>>>     vsl_b_write(os, v.columns());
>>> }
>>>
>>> was invoked the vsl_b_write corresponding to an unsigned int data type.
>>>
>>> But in
>>> void vsl_b_read(vsl_b_istream &is, vnl_sparse_matrix<T> & p)
>>> {
>>>      ...
>>>       int n_rows;
>>>       int n_cols;
>>>       ...
>>>       vsl_b_read(is, n_rows);
>>>       vsl_b_read(is, n_cols);
>>>      ...
>>> }
>>> was invoked the int version of the vsl_b_read. I simply change de data
>>> type of n_rows, and n_cols from int to unsigned int, and apparently
>>> works.
>>>
>>> --- core/vnl/io/vnl_io_sparse_matrix1.txx       2013-02-28
>>> 13:47:05.216041425 -0300
>>> +++ core/vnl/io/vnl_io_sparse_matrix.txx        2013-02-28
>>> 13:42:16.999376554 -0300
>>> @@ -111,8 +111,8 @@
>>>    #endif
>>>
>>>      short ver;
>>> -  int n_rows;
>>> -  int n_cols;
>>> +  unsigned int n_rows;
>>> +  unsigned int n_cols;
>>>      int row_size=0;
>>>      vsl_b_read(is, ver);
>>>    int aa = is.is().tellg();
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Everyone hates slow websites. So do we.
>>> Make your web apps faster with AppDynamics
>>> Download AppDynamics Lite for free today:
>>> http://p.sf.net/sfu/appdyn_d2d_feb
>>> _______________________________________________
>>> Vxl-users mailing list
>>> Vxl...@li...
>>> https://lists.sourceforge.net/lists/listinfo/vxl-users
>>>
>>
>