From: Osullivan L. <L.O...@sw...> - 2012-04-04 14:09:29
|
Hi Folks, You could add an isILLRequest value to the holdings array - that way, when you get to the placeHold function, you can check for it and then use send the details to _checkMethodILLs.You shouldn't have to change any of the core code then... Cheers, Luke -----Original Message----- From: Alan Rykhus [mailto:ala...@mn...] Sent: 04 April 2012 15:01 To: vuf...@li... Subject: Re: [VuFind-Tech] HoldLogic.php addLink variable question Hello Demian, Actually there are special occasions when we let the patron choose between ILL and a hold. We have some Aleph ADMs that have multiple libraries across larger areas. They let their patrons decide how they want to handle things. Its mostly where the patrons want to pick up the item. I like starting with HoldLogic because it handles the logon for the patron, we really only want one link for logging on. Its after the patron logs on and I examine the item and patron that I can determine what link to put up. To start with I was going with the Hold OR ILL link. I was going to look at the special cases afterwards. Just adding the simple case is a bit of coding. Because it is not just creating ILL requests. I also need to go into MyResearch and add displaying, canceling, and renewing ILLs. Then there is creating ILL requests from a blank form. All things that are important to us and available through the Aleph Restful API. I'm attempting to do this with as little disruption to the current code as I can. I'm hoping to just add new classes that are only used for ILL. I've modified HoldLogic.php and it looks like I'll have to add a function to CatalogConnection.php as it has a _checkMethodHolds function and I'll need a _checkMethodILLs fuinction. al On Wed, 2012-04-04 at 09:47 -0400, Demian Katz wrote: > Will there be situations where a user might have a choice between ILL > and a hold? In that situation, would it be better to have a separate > 'illLink' element rather than a reserved value in 'addLink'? > > - Demian > ________________________________________ > From: Alan Rykhus [ala...@mn...] > Sent: Tuesday, April 03, 2012 2:20 PM > To: vuf...@li... > Subject: [VuFind-Tech] HoldLogic.php addLink variable question > > Hello, > > I'm working with my Aleph Driver again, trying to add ILL links and > functionality. Since we are a consortia, our patrons can place holds > or ILL requests on items. I'm trying to add this functionality just > using the driver and hit a slight stumbling block. > > In HoldLogic.php, in the function driverHoldings there is a call to > see if $copy['addLink'] is basically not false. > > In creating my hold links this is not a problem. It then calls > _getHoldDetails and rebuilds the hold link, adding the data needed in > the configured HMACKeys. > > I would like to change this call so that it looks to see if > $copy['addLink'] has a string value of ILL. I realize I can do this in > my own code, but I'm trying to keep as close to the trunk as I can. So > I was looking at changing this to: > > if addLink = ILL > _getILLDetails > else if addLink > continue as is now. > > I would then add a _getILLDetails function. > > Does this seem OK to those who don't have ILL? > > thanks -- al > -- > Alan Rykhus > PALS, A Program of the Minnesota State Colleges and Universities > (507)389-1975 > ala...@mn... > "It's hard to lead a cavalry charge if you think you look funny on a > horse" ~ Adlai Stevenson > > > ---------------------------------------------------------------------- > -------- Better than sec? Nothing is better than sec when it comes to > monitoring Big Data applications. Try Boundary one-second resolution > app monitoring today. Free. > http://p.sf.net/sfu/Boundary-dev2dev > _______________________________________________ > Vufind-tech mailing list > Vuf...@li... > https://lists.sourceforge.net/lists/listinfo/vufind-tech -- Alan Rykhus PALS, A Program of the Minnesota State Colleges and Universities (507)389-1975 ala...@mn... "It's hard to lead a cavalry charge if you think you look funny on a horse" ~ Adlai Stevenson ------------------------------------------------------------------------------ Better than sec? Nothing is better than sec when it comes to monitoring Big Data applications. Try Boundary one-second resolution app monitoring today. Free. http://p.sf.net/sfu/Boundary-dev2dev _______________________________________________ Vufind-tech mailing list Vuf...@li... https://lists.sourceforge.net/lists/listinfo/vufind-tech |