Re: [VuFind-Tech] Lightbox tweaks

[Eoghan Ó C. <eog...@gm...>]

Hi Luke,
That's a much better solution, thanks! I just submitted the improved patch
to JIRA.

All the best,
Eoghan

2009/10/5 Osullivan L. <L.O...@sw...>

>  Hi Eoghan,
>
>
>
> I’ve used a lightbox in the past which was added after the DOM had loaded.
> That way it could get the exact height and width of the page and apply the
> style as appropriate. Perhaps this might be a way to avoid browser sniffing?
>
>
>
> Cheers
>
>
>
> Luke
>
>
>  ------------------------------
>
> *From:* Eoghan Ó Carragáin [mailto:eog...@gm...]
> *Sent:* 04 October 2009 11:47
> *To:* Greg Pendlebury
> *Cc:* vuf...@li...
> *Subject:* Re: [VuFind-Tech] Lightbox tweaks
>
>
>
> Hi,
>
> I've just submitted a patch (VUFIND-100 in JIRA) which adds a few more
> lightbox tweaks:
>
>    - the #lightbox div now covers the full page rather than the viewport
>    (i.e. when the user scrolls, everything is faded except the popup box)
>    - the cursor css property of the lightbox header is set to 'move' to
>    highlight the fact that it can be dragged
>
> There were various ways to get the background colour to cover the
> full-page, but this is the only combination that I could find that worked in
> IE and other browsers:
>
>    - For Firefox, Chrome etc, all that was needed was to set the position
>    property to 'fixed' and remove the line in scripts.js that recalculated the
>    scroll position of the #lightbox div, but this didn't work in IE6 or IE8 (!
>    eventhough IE8 supports position:fixed)
>    - For IE6 & IE8 (and IE7, I hope), it could be accomplished by adding
>    an outer parent <div class="lightboxOuterDiv"> with a height of 100% and
>    removing the js line, but this did nothing in Firefox et al. I'm not sure
>    why a new parent div was necessary as both body and html elements already
>    had a height of 100%.
>    - My solution was to add the parent div for IE, make the position:fixed
>    change for other browsers, and then reset position:fixed to
>    position:absolute for IE only in scripts.js. Ideally, i'd rather not have to
>    use this javascript for browser-specific action, but it seems to work, and
>    this is probably more future-proof than any of the CSS hacks etc.
>
> Please test. Thanks,
> Eoghan
>
> 2009/9/3 Greg Pendlebury <Gre...@us...>
>
> Finally getting around to following up on half done jobs this week. r1351
> is in trunk now (and patch attached) with the lightbox changes and YUI
> scrollTop code.
>
>
>
> I'm trying out winmerge too. It still has the padding style in the patch
> but presumably that's from the old diff against the USQ branch. I'll keep an
> eye out for improvements winmerge brings.
>
> *Greg Pendlebury*
> Electronic Services Officer (Systems Team)
> Division of Academic Information Services
> University of Southern Queensland
> Phone: +61 7 4631 1501
> Fax: +61 7 4631 1841
>
>
>
>
>  ------------------------------
>
> *From:* Demian Katz [mailto:dem...@vi...]
>
> *Sent:* Tuesday, 25 August 2009 10:31 PM
>
>
> *To:* Greg Pendlebury; vuf...@li...
> *Subject:* RE: Lightbox tweaks
>
>
>
> 1) I was never bothered by the missing cursor even when it didn't work, but
> I've added it as a possible solution to people who want the 'anchor' like
> functionality. Easy to comment out of the stylesheet though.
>
>
>
> Fair enough.
>
>
>
> 2) I'll switch to the YUI call. It wasn't in the trunk when I patched
> against it, is it local to the VU codebase?
>
>
>
> The YUI call didn't actually come from any existing codebase -- I just
> looked it up and tested it yesterday since I figured there might be an
> existing YUI alternative to the more complex code.
>
>
>
> 3) No idea, I didn't touch it :) I'm growing to not like some subtle things
> about tortoise svn on our laptop, but it hasn't broken anything significant
> yet.
>
>
>
> Have you tried WinMerge?  If you install it, it plugs into TortoiseSVN and
> replaces the built-in merge/diff tool; I like it a little bit better.  I
> don't know that it will help with the problems you're having, but you might
> want to take a look at it.
>
>
>
> - Demian
>    ------------------------------
>
> This email (including any attached files) is confidential and is for the
> intended recipient(s) only. If you received this email by mistake, please,
> as a courtesy, tell the sender, then delete this email.
>
> The views and opinions are the originator's and do not necessarily reflect
> those of the University of Southern Queensland. Although all reasonable
> precautions were taken to ensure that this email contained no viruses at the
> time it was sent we accept no liability for any losses arising from its
> receipt.
>
> The University of Southern Queensland is a registered provider of education
> with the Australian Government (CRICOS Institution Code No's. QLD 00244B /
> NSW 02225M)
>
>
>
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
> trial. Simplify your report design, integration and deployment - and focus
> on
> what you do best, core application coding. Discover what's new with
> Crystal Reports now.  http://p.sf.net/sfu/bobj-july
> _______________________________________________
> Vufind-tech mailing list
> Vuf...@li...
> https://lists.sourceforge.net/lists/listinfo/vufind-tech
>
>
>