Re: [VuFind-Tech] JIRA patches: VUFIND-3 & VUFIND-7

[Lovins, D. <dan...@ya...>]

Hi Eoghan.

I was trying out your suggested fix for VUFIND-7,


Old - bug:
<a href="{$url}/Search/{$action}?lookfor={$lookfor|escape}&type={$type}&view=rss" class="feed">{translate text='Get RSS Feed'}</a>

New - fixed(?):
<a href="{$fullPath}&view=rss" class="feed">{translate text='Get RSS Feed'}</a>


When I tried to generate the RSS, though, I receive a mostly blank yellow-background screen with the message: "Warning:  Wrong parameter count for XSLTProcessor::setParameter() in [...] \web\services\Search\Home.php on line 605"

Here's line 605 from Home.php:

$xsl->setParameter('', 'lookfor', $_GET['lookfor']);

So does this file/line need to be changed as well?

Thanks!

Daniel




From: Eoghan Ó Carragáin [mailto:eog...@gm...]
Sent: Thursday, September 03, 2009 8:43 PM
To: vuf...@li...
Subject: [VuFind-Tech] JIRA patches: VUFIND-3 & VUFIND-7

Hi,
I have uploaded/commented patches for the following JIRA tickets:

 *   VUFIND-3<http://www.vufind.org/jira/browse/VUFIND-3> - Search History does not keep track of facets (fixed bug & made minor improvements)
 *   VUFIND-7<http://www.vufind.org/jira/browse/VUFIND-7> - RSS feed omits narrowing filters.

As discussed recently, it would be great to close off the some of the open issues in JIRA. It seems quite a few of the tickets have suggested fixes and/or uploaded patches; also, others may be redundant now.
Eoghan