From: Greg P. <pen...@us...> - 2009-05-18 01:20:36
|
I'd say Jira sounds good Franck, we can all get it there, including Andrew. I like the factory pattern idea, but where it appears in the codebase I'm not so sure about. MyResearch is where all the local database code is. When I first started I found the name and location confusing. What isn't there is business logic relating to session/authentication, and I kind of like that distinction. Having implemented Chris's patch for database session storage we are now looking at 4 tiers of code for user handling: -------------------- index.php => /sys/User.php ==> /sys/MySQLSessions.php ===> /services/MyResearch/lib/* (Sessions & Users) -------------------- If anything I'd prefer to see the DataObject stuff come out of MyResearch and rework /sys -------------------- /sys/database/* <= All the DataObject stuff currently nested under MyResearch (no business logic) /sys/sessions/* <= Authentication and session handling (including the factory object) /sys/datasources/* <= Solr... perhaps more with growth /sys/util/* <= The rest... -------------------- Those are just my quick thoughts, but ultimately, whilst I like the idea, and think it's necessary... it's not a high priority from our perspective. Greg Pendlebury Electronic Services Officer (Systems Team) Division of Academic Information Services University of Southern Queensland Phone: +61 7 4631 1501 Fax: +61 7 4631 1841 -----Original Message----- From: Franck Borel [mailto:fra...@gb...] Sent: Thursday, 14 May 2009 10:46 PM To: vuf...@li... Subject: Re: [VuFind-Tech] Add Shibboleth/SimpleSAMLphp authentication method Hi Andrew, I have written the necessary code to shib-enable vufind. In witch form should I commit the code? Should I post the entire vuFind code with the changes or only the changed code (I don't have access to the svn, so I will post the code in Jira)? Furthermore I would like to change the structure of the authentication process. At the moment the authentication process is coded in the index.php. The code should be moved in the MyResearch. I would like to use a factory pattern to bind the different authentication methods. Is this ok? Have a nice day! -- Franck ------------------------------------------------------------------------------ The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your production scanning environment may not be a perfect world - but thanks to Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700 Series Scanner you'll get full speed at 300 dpi even with all image processing features enabled. http://p.sf.net/sfu/kodak-com _______________________________________________ Vufind-tech mailing list Vuf...@li... https://lists.sourceforge.net/lists/listinfo/vufind-tech This email (including any attached files) is confidential and is for the intended recipient(s) only. If you received this email by mistake, please, as a courtesy, tell the sender, then delete this email. The views and opinions are the originator's and do not necessarily reflect those of the University of Southern Queensland. Although all reasonable precautions were taken to ensure that this email contained no viruses at the time it was sent we accept no liability for any losses arising from its receipt. The University of Southern Queensland is a registered provider of education with the Australian Government (CRICOS Institution Code No's. QLD 00244B / NSW 02225M) |