#69 Default Color Background

closed-fixed
nobody
Interface (19)
3
2010-12-21
2010-11-06
Terry
No

I added a ~/.viking/maps.xml to get TopOSM maps loaded.
Once I had the syntax corrected it turned the background
solid black instead of the nice tan color. Bascially changed
files to be downloaded from .png to .jpg
I'm not sure if this really bug a setting but wanted to report
on it.

Discussion

    • status: open --> pending-works-for-me
     
  • Terry
    Terry
    2010-11-27

    ~/.viking/maps.xml

     
    Attachments
  • Terry
    Terry
    2010-11-27

    Attached a copy of my maps.xml
    <object class="VikSlippyMapSource">
    <property name="label">TopOSM-ColorRelief</property>
    <property name="hostname">tile1.toposm.com</property>
    <property name="url">/us/color-relief/%d/%d/%d.jpg</property>
    <property name="id">206</property>
    </object>
    <object class="VikSlippyMapSource">
    <property name="label">TopOSM-Contours</property>
    <property name="hostname">tile1.toposm.com</property>
    <property name="url">/us/contours/%d/%d/%d.png</property>
    <property name="id">207</property>
    </object>
    <object class="VikSlippyMapSource">
    <property name="label">TopOSM-Features</property>
    <property name="hostname">tile1.toposm.com</property>
    <property name="url">/us/features/%d/%d/%d.png</property>
    <property name="id">208</property>
    </object>
    It turns the background black on viking if there is no maps loaded or selected.

     
  • Terry
    Terry
    2010-11-27

    • priority: 5 --> 3
    • status: pending-works-for-me --> open-works-for-me
     
  • Rob Norris
    Rob Norris
    2010-11-29

    Regarding the colour:
    Oops, I inadvertently broke it - in commit SHA1: 348e86667fea13b65d71e4fbe9bf1a2b8ed84f6f
    For a new session, the *text* of the background colour is never actually set, thus it defaults to zero (which is black)
    So the bug will be present in versions 0.9.96 + 1.0.0

    I've submitted a patch to fix it, to the viking-dev mailing list.
    It should be in the source / release soon...

    NB I think this should be added into the 1.0.XYZ fix release.

    NB2 Thus it is unrelated to your setup, so thanks for the bug report!

     
  • Patch applied both on branches master and viking-1.0.z.

     
    • status: open-works-for-me --> pending-fixed
     
    • status: pending-fixed --> closed-fixed
     
  • This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 21 days (the time period specified by
    the administrator of this Tracker).