Re: [vassalengine-devel] Rational class
Brought to you by:
rodneykinney,
uckelman
From: Joel U. <uck...@no...> - 2007-08-29 09:40:37
|
Thus spake "Rodney Kinney": > > > I was planning on that also. Once you start using Rationals for the > > scale factor one place you need to use them everywhere, or else you'll > > have occasional oddness due to accumulated error in floating point > > arithmetic. > > > This is where the payoff is questionable. I don't want to change, for > example, the GamePiece.draw() method to use Rational instead of double. Too > high impact for too little gain. If we do refactor the various draw() > methods (GamePiece, Map, Board), the direction I'd like to take it is to > pass in an AffineTransform instead of int x, int y, double zoom. > > rk Have you ever noticed tokens "wandering" as you change the zoom level? Keeping the zoom level as a Rational everywhere would solve that, I think. -- J. |