Re: [Valgrind-developers] Valgrind: r13706 - /trunk/drd/drd_strmem_intercepts.c

[Дмитрий Д. <di...@gm...>]

Hello Bart!
Thank you for clarification!
Dmitry
30.10.2013 18:03 пользователь "Bart Van Assche" <bva...@ac...>
написал:

> On 30/10/2013 6:30, Дмитрий Дьяченко wrote:
>
>> Hi!
>> Only curiosity: why its not possible to use memcheck/mc_replace_strmem.c ?
>> I try the following patch and 'make regtest' show no new FAIL. Fedora
>> 19/x64/gcc-4.8.2 V-trunk
>>
>> If my observation is correct then, probably, V may have only one file
>> with interceptions?
>>
>> Dmitry
>>
>>
>> valgrind]$ svn diff
>> Index: drd/Makefile.am
>> ==============================**==============================**=======
>> --- drd/Makefile.am    (revision 13706)
>> +++ drd/Makefile.am    (working copy)
>> @@ -124,7 +124,8 @@
>>   VGPRELOAD_DRD_SOURCES_COMMON = \
>>     drd_pthread_intercepts.c     \
>>     drd_qtcore_intercepts.c      \
>> -  drd_strmem_intercepts.c
>> +  ../memcheck/mc_replace_strmem.**c
>> +  # drd_strmem_intercepts.c
>>
>>   if VGCONF_OS_IS_DARWIN
>>   VGPRELOAD_DRD_SOURCES_COMMON += drd_darwin_intercepts.c
>>
>
> Hello Dmitry,
>
> Merging the strmem intercepts in memcheck/mc_replace_strmem.c,
> drd/drd_strmem_intercepts.c and helgrind/hg_intercepts.c is something that
> is on my to-do list. My plan is to have a closer look at this once I'm back
> home (I'm traveling now). The above patch is wrong though because it
> removes the *_sse* intercepts from drd and hence would reintroduce bugs
> like https://bugs.kde.org/show_bug.**cgi?id=326623<https://bugs.kde.org/show_bug.cgi?id=326623>
> .
>
> Bart.
>
>