Re: [Valgrind-developers] Valgrind trunk on arm : mmap2 receives wrong parameters

[J W <jwd...@go...>]

Actually it seems that "stock" VG is taking care of the additional
alignment requirements of (some?) arm platforms already on other
places, e.g (syswrap-generic.c).
   if (arg1 == 0) {
      /* arm-linux only: work around the fact that
         VG_(am_get_advisory_client_simple) produces something that is
         VKI_PAGE_SIZE aligned, whereas what we want is something
         VKI_SHMLBA aligned, and VKI_SHMLBA >= VKI_PAGE_SIZE.  Hence
         increase the request size by VKI_SHMLBA - VKI_PAGE_SIZE and
         then round the result up to the next VKI_SHMLBA boundary.
         See bug 222545 comment 15.  So far, arm-linux is the only
         platform where this is known to be necessary. */
      vg_assert(VKI_SHMLBA >= VKI_PAGE_SIZE);
      if (VKI_SHMLBA > VKI_PAGE_SIZE) {
         segmentSize += VKI_SHMLBA - VKI_PAGE_SIZE;
      }

Given that, is it still considered as too much work for old
architectures putting sth. similar into the mmap wrapper?

Joerg