Re: [uml-devel] Re: [PATCH] kernel_thread()/fork()

[Jeff D. <jd...@ka...>]

Good patch.  Most patches I get just whack in new code and don't attempt to
take advantage of cleanups that become possible.  Although I did clean it
up somewhat more agressively than you.

I changed a couple of things, so you probably want to see if I broke anything.

You dropped the initialization of a kernel thread's mm and active_mm:

	new_task->mm = NULL;
	new_task->active_mm = NULL;

I put them back.

Rather than leave kernel_thread1 where it is, I moved it to smp.c and gave
it a sane name.  Also, since it's now so special-purpose, its argument list
can be shortened.

I dropped the schedule() from kernel_thread() and also the 
current->need_resched that I had put there eons ago.

The end result seems functionally identical to your patch and it seems to
behave itself.

				Jeff