Re: [uml-devel] [PATCH 1/6] UML - Customize tlb.h

[Jeff D. <jd...@ad...>]

On Thu, Dec 06, 2007 at 11:46:42AM -0800, Andrew Morton wrote:
> > +void flush_tlb_mm(struct mm_struct *mm)
> > +{
> > +	struct vm_area_struct *vma = mm->mmap;
> > +
> > +	if (atomic_read(&mm->mm_users) == 0)
> > +		return;
> 
> Under which circumstances does this test succeed?

Sigh, none.  The other copy obviously succeeds during exit - this one
isn't needed.

> This file rather needs an inclusion of percpu.h.  I guess you got
> lucky.

Yup, drop this, and I'll send a fixed version.

				Jeff

-- 
Work email - jdike at linux dot intel dot com