Re: [uml-devel] Hostfs permission checks are all wonky.

[Rob L. <ro...@la...>]

On Tuesday 22 March 2005 02:19 pm, Blaisorblade wrote:

> Ok, I'm now seeing that UML uses access() (inside access_file()) to check
> permissions.
>
> See hostfs_permission -> access_file -> access. hostfs_permission (not
> access_file) should skip the "access_file" call in case its type is
> OS_TYPE_CHARDEV / OS_TYPE_BLOCKDEV / OS_TYPE_FIFO / OS_TYPE_SOCK.
>
> Look at init_inode() about how to see the file's type, but even better look
> at the cached information, i.e. inode->i_mode and the S_* access macro
> (look at init_special_inode about this).

Just confirming: this patch fixed it.  Both /dev/loop0 and /dev/console work 
just fine with hostfs root now.

Can this patch make it into 2.6.12?

Rob