From: Waschk,Kolja <ur...@ix...> - 2008-02-25 22:08:21
|
Hi Jie, I hope you don't mind if I answer to the list: > The coding style is another question I want to ask. > 1. ChangeLog coding style. The current coding style of ChangeLog is not a GNU > one, at least it's different with other projects I'm familiar with, like gcc, > gdb and binutils. UrJTAG is not part of GNU project, so it might be not > required to follow the GNU style of ChangeLog. But vim displays white spaces > for the leading blanks, which looks a little weird. But this is not a big > problem. I can follow the established convention. At some day we could adopt the svn2cl output format, it claims it does it "GNU style" (lines prefixed with a Tab); but at that time it should be reformatted as a whole. > 2. Souce code coding style. It seems the coding style of most source code of > UrJTAG is not GNU nore Linux. For example, the function call looks like: [...] > What's the current requirement on coding style? Should I format my patches > now or you will do it in future for the whole UrJTAG? In general, GNU coding style should be followed. Where missing, emacs and vi initialization code should be added to the source files. At some day there'll be large scale reformatting and renaming of many functions in order to make all names "UrJTAG-local" for use as a library. I'll use "indent -nut" to do so, which also will nuke tabs. Kolja |