Re: [Unichrome] Odd code in ViaModePrimaryVGA()

[Barry S. <bar...@on...>]

Luc Verhaegen wrote:
> On Tue, Jun 13, 2006 at 01:47:39PM +0100, Barry Scott wrote:
>   
>> Oh thanks. Too much hex confused me. I misread 0x0c for 0xc0.
>>
>> To document things it would be great to see symbols used for these
>> bits.
>>
>> Barry
>>
>>     
> MiscOut is plain and standard VGA stuff, and imminently readable to 
> those used to poking VGA stuff.
>   
I work on a lot of drivers and the use of HEX is a barrier to understanding.
Your code would be more maintainable without the HEX. Your not the worst
HEX coder that prize belongs to the V4L driver writers. No commercial
software organisation I have worked for would allow the HEX in production
code.
> Convinced about the uses of proper modesetting versus VBE yet, Barry?
>   
I never needed convincing about mode settings. Not sure what I might 
have written
to give you the impression that I want VBE over mode setting. Indeed I'm 
currently
battling with the i810 driver to support 1280x768 on the i945G chipset 
that only
has VBE and apparently no way to set the mode.

Barry