#286 Ufraw uses crop aspect ratio of previous image
This bug was originally submitted for Fedora: https://bugzilla.redhat.com/show_bug.cgi?id=634235
I've imported the CVS history into git and bisecting found two commits which have contributed to the issue, see below. I have verified that this issue still exists with the current CVS HEAD.
=============================================================================
[reply] [-] Private Description R. Steven Rainwater 2010-09-15 11:33:28 EDT
Description of problem:
Just upgraded via yum to the new version of ufraw. The new version has a
problem adjusting to successive images that have different aspect ratios. It
appears to be remembering the aspect ratio of the previous image and trying to
apply it to the new one.
For example, if you load a landscape aspect ratio image followed by a portrait
aspect ratio image, ufraw doesn't display the portrait mode image correctly; it
displays with landscape aspect ratio crop markings on as if it thinks you want
to crop off the top and bottom. The only way to fix it is to manually go the
"crop and rotate" tab on every new shot you load and hit the "reset crop
region" button.
Version-Release number of selected component (if applicable):
ufraw-0.17-1.fc13.x86_64
How reproducible:
always
Steps to Reproduce:
1. load a landscape aspect ratio image
2. save image
3. load a portrait aspect ratio image
Actual results:
the portrait aspect ratio image is displayed with a small, landscape mode crop
box covering the center and the rest of the image is greyed out
Expected results:
the portrait aspect ratio image should be displayed normally with no crop
markings
Additional info:
this worked fine on ufraw-0.16 and all previous versions
the only work-around I've discovered so far it to go to the crop and "rotate
tab" and click the reset "crop region button". This will need to be done on
every image loaded unless the new image is coincidentally of the exact same
aspect ratio as the previous one.
[...]
[reply] [-] Private Comment 3 Nils Philippsen 2011-06-01 06:01:30 EDT
This is the first commit in which I see problems with crop markings:
commit 0748998828b2f8a15e28e6e19d53c66d97608355
Author: udifuchs <udifuchs>
Date: Sun Feb 21 10:03:55 2010 +0000
Initial implimentation if lensfun with UFObjects.
Lensfun model parameters are being saved to ID files, but not to .ufrawrc.
These parameters will be also read from ID files, unless the ID file
is used for --conf.
UFRaw now applies lensfun automatically. Use --lensfun=none to disable.
Makefile.am | 4 +-
uf_gtk.cc | 69 ++++++---
uf_gtk.h | 1 +
ufobject.cc | 288 ++++++++++++++++++++++++++++++++++----
ufobject.h | 82 +++++++++--
ufraw-batch.c | 15 +--
ufraw.c | 15 +--
ufraw.h | 15 ++-
ufraw_conf.c | 114 ++++++++++++---
ufraw_lens_ui.c | 400 +++++++++++++++--------------------------------------
ufraw_lensfun.cc | 335 ++++++++++++++++++++++++++++++++++++++++++++
ufraw_preview.c | 32 +++--
ufraw_settings.cc | 46 +++++--
ufraw_ufraw.c | 90 +++---------
ufraw_ui.h | 9 +-
15 files changed, 1005 insertions(+), 510 deletions(-)
Note that here the aspect ratio of the crop markings is correct, they are just
too small for the image.
[reply] [-] Private Comment 4 Nils Philippsen 2011-06-01 06:07:37 EDT
This is the first commit in which I see crop markings with the wrong aspect
ratio (portrait instead of landscape in my tests):
commit e132d5a799351dd0429cdddabfa2a19d3f2b0173
Author: udifuchs <udifuchs>
Date: Fri Feb 26 07:01:04 2010 +0000
Add ufFocalLength, ufAperture, ufDistance UFObjects.
Doxyfile | 4 +-
uf_gtk.cc | 49 ++++++++--
uf_gtk.h | 1 +
ufobject.cc | 37 +++++---
ufobject.h | 7 ++
ufraw.h | 6 +
ufraw_lens_ui.c | 198 ++++++---------------------------------
ufraw_lensfun.cc | 270 ++++++++++++++++++++++++++++++++++++++++++-----------
ufraw_preview.c | 6 +-
ufraw_settings.cc | 9 +--
ufraw_ufraw.c | 1 -
ufraw_ui.h | 10 --
12 files changed, 329 insertions(+), 269 deletions(-)
I can confirm this problem is still present.
Regards,
Niels Kristian
It is now fixed in CVS.
Udi
Thanks a lot! I've applied the patch from CVS to 0.18 and verified that it fixes the issue.