From: <Wil...@nt...> - 2005-05-29 02:45:10
|
Author: WillNorris Date: 2005-05-28 19:45:00 -0700 (Sat, 28 May 2005) New Revision: 4339 Modified: twiki/branches/DEVELOP/lib/TWiki/UI/Manage.pm Log: CodeSmell: Modified: twiki/branches/DEVELOP/lib/TWiki/UI/Manage.pm =================================================================== --- twiki/branches/DEVELOP/lib/TWiki/UI/Manage.pm 2005-05-29 02:40:41 UTC (rev 4338) +++ twiki/branches/DEVELOP/lib/TWiki/UI/Manage.pm 2005-05-29 02:45:00 UTC (rev 4339) @@ -356,6 +356,7 @@ if( $parent && $parent->{name} && $parent->{name} ne $oldTopic && $store->topicExists( $session->normalizeWebTopicName( '', $parent->{name} ) ) ) { + # SMELL: probably would prefer some sort of normalizeWebTopicName() call here instead if ( $parent->{name} =~ /([^.]+)[.]([^.]+)/ ) { $new_url = $session->getScriptUrl( $1, $2, 'view' ); } else { |