Re: [TrouSerS-tech] Re-submit of the trousers patch after modifying as your suggestions

[Kent Y. <shp...@gm...>]

Hi James,

  It looks like there will still be an error thrown before
Tspi_NV_DefineSpace falls back to the context's default policy:

+       if ((result = obj_nvstore_get_policy(hNvstore, &hEncPolicy)))
+               return result;
+
+       if (need_authdata && !hEncPolicy) {
+               result = TSPERR(TSS_E_BAD_PARAMETER); /* need to
define the policy; */
+               return result;
+       }
+
+       if (!hEncPolicy) {
+               if ((result = obj_context_get_policy(tspContext, &hEncPolicy)))
+                       return result;
+       }
+

  Also, please leave out the chunk in src/tspi/tspi_pcr_comp12.c,
since it makes the code less readable.

  I see that there's also a hidden bugfix in src/tspi/tspi_own.c. :-)
I'll apply this separately, please remove it from the patch.  Each
feature/bugfix should be in its own separate patch.

Thanks,
Kent

On 6/6/07, Xu, James <jam...@in...> wrote:
> Hi Kent,
>
> We have changed the trousers according to your suggestions. And we have re-validated the new codes again. Please help review it again.
>
> Thanks,
> James

-- 
Kent Yoder
IBM LTC Security Dev.