[Tripwire-dev] typo in src/core/msystem.cpp?

[Paul H. <ph...@fr...>]

Hi tripwire-dev,

A purely academic observation:

I think I've found a typo in msystem.cpp.  Is there any Unix on the
planet that defines SIGCLD and not SIGCHLD?

I say it's academic, because in spite of this "typo", luckily Open
Source Tripwire seems to Do The Right Thing on the platforms it
supports.  I have, however, seen it hang in wait() on one OS and
ECHILD from wait() on another because SIGCHLD was ignored.

-Paul.

Index: msystem.cpp
===================================================================
RCS file: /u01/home/pherman/etc/cvsroot/tripwire/src/core/msystem.cpp,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- msystem.cpp	14 Aug 2002 21:27:11 -0000	1.2
+++ msystem.cpp	31 May 2003 03:31:58 -0000	1.3
@@ -953,8 +953,8 @@
 			 * ignore any signals until child dies
 			 */
 			for(i = 0; i < MAX_SIGNAL; i++)
-#ifdef SIGCLD
-				if (i != SIGCLD)
+#ifdef SIGCHLD
+				if (i != SIGCHLD)
 #endif
 					savesig[i] = tw_sigign(i);
 			/*