From: Stefan B. <st...@li...> - 2013-04-22 13:04:30
|
On 01/23/2013 11:11 AM, Stefan Berger wrote: > On 01/22/2013 06:25 PM, Kent Yoder wrote: >> Hi Stefan, >> >> On Tue, Jan 22, 2013 at 10:09:43AM -0500, Stefan Berger wrote: >>> V3: >>> - use TPM vendor ID to differentiate status flag checking for detecting >>> command cancellation >> Excellent, thanks Stefan. As I mentioned in chat, my STM TPM thought >> every command was cancelled, so something vendor specific was going to >> be needed. >> >> I made a couple of tweaks to your patches, 1) to add the STM VID and >> check for the right status on cancel there and 2) make >> wait_for_tpm_stat_cond() static. I wasn't able to put either of my TPMs >> into interrupt mode to test that patch though. I also updated the new STM >> I2C driver's req_canceled function. > The worst thing that can happen in interrupt mode is that the > cancellation does not cause an interrupt and the process continues > waiting for the command to complete. It only wakes up after the timeout > expires and then sees that the command was canceled when reading the > status register... > >> I've staged these patches here: >> >> https://github.com/shpedoikal/linux.git tpmdd-01-22-13 I haven't checked in a while, but I don't see that these patches made it into the repository. Were there rejections regarding these patches or did they just get lost on the way? Stefan |