From: Bjorn H. <bjo...@hp...> - 2006-07-26 03:14:17
|
tpm_infineon.c and tpm_tis.c use pnp_register_driver() to bind to devices with matching PNP IDs. That seems like the right way to do it. But tpm_atmel.c and tpm_nsc.c just blindly poke around looking for their device. That seems wrong. Is there some reason they can't use pnp_register_driver() also? I'd be glad to send a patch to fix this if somebody knows the appropriate list of PNP IDs that these drivers should claim. I like the recent tpm_tis.c changes to give a hook for use when ACPI doesn't correctly describe the TPM device. That will give manufacturers a hint that they're doing something wrong. Bjorn |