R: [Tora-develop] A small patch to tora

[Dandrea F. <fra...@te...>]

First, the answer to your questions:
1) Because I have instelled Mingw in C:\Program Files\msys\1.0\mingw. As =
you can see there is a blank in the directory path(Program Files), and =
without the changes I did in the makefile Tora doesn't compile (winres =
said something like impossible to execute C:\Program ).
2) the method toBreakpointItem::clearBreakpoint() signature changes =
because now it manages the fact that the removal of a brekpoint can =
fail. In this case you should not remove the brekpoin item from the =
breakpoint table. If the removal fails the method returns <0, else it =
returns 0.
=20
Now the reason I sent you the patchses. I'm out of time for the moment, =
but some thing in the patch is right, and the behaviur is not worse than =
the previous one. Maybe in may i can have more time, or maybe someone =
else can see the code and understand why it doesn't work.
The thing I think that are right:
1) -      toQuery query(conn,SQLBreakpoint);
  +      toQuery query(conn,SQLClearBreakpoint);
=20
is surelly right (before when you tried to remove a brekpoint the SQL to =
add a brekpoint was called).
2) the management of the failure during removal of a brekpoint can be a =
nice thing to have.
3) without the patch to windows/Makefile Tora doesn't compile here.
=20
Ciao (and thanks for the Mingw build by the way. I hope that the problem =
with the text area will be solved, but I don't think this is an easy =
task).


________________________________

	Da: Alexey Danilchenko [mailto:a.d...@se...]=20
	Inviato: marted=EC 29 marzo 2005 10.24
	A: Dandrea Francesco; Tora List
	Oggetto: RE: [Tora-develop] A small patch to tora
=09
=09
	I am not quite sure what is it you want us to do with this code? Also =
you stated (3) that the Mingw/Msys somehow affect the TOra execution =
after the build - how is that? TOra does not use anything from Mingw =
apart from threading dll if compiled with mthread option - in this case =
all you have to do is copy mingwm10.dll to tora directory.
	=20
	A couple of questions about the source changes you did:
	=20
	1) Why did you changes the resource compilation in a makefile if there =
are no resource changes involved in your patch?
	2) Why the method signature for toBreakpointItem::clearBreakpoint() was =
changed - there wern't any changes to the code that calls it?
	=20
	Alexey
	=20
	=20

		-----Original Message-----
		From: Dandrea Francesco [mailto:fra...@te...]
		Sent: Tuesday, March 29, 2005 8:56 AM
		To: Tora List
		Subject: [Tora-develop] A small patch to tora
	=09
	=09
		=20
		As you probably know, in Tora's PL/SQL Debugger is possible to set a
		breakpoint, but then you can't remove it (when you try, the red dot is
		removed but the debugger stops when it hits the brekpoint line).
		Since I saw that there is a MingW build of tora and I had a day of =
free
		time, I builded Tora, and looked to the problem.
		No, I didn't solve it, I'm sorry. But I did some step:
		1) now it calls the right SQL to remove the breakpoint and not the one
		to set it again. Now it gives an error (error code 1884 or 1888, not
		documented from the dbms_debug package. I don't know maybe the SQL is
		wrong...)
		2) when the breakpoint removal fails the row is not removed from the
		breakpoint table
		3)If you installed Mingw and MSys in a directory with spaces in the
		name, now it works.
	=09
		I'm sending this now because, well my free day is gone and I will be
		very busy in the next months, and maybe the changes I did can be =
usefull
		to somene looking the same problem.
	=09
		PS: I can't CVS (firewall problem) and so the patches are all against
		Tora 1.3.16. The patched files are todebugtext.cpp, todebugtext.h and
		window/Makefile.
	=09
		Ciao
	=09
	=09
	=09
		--------------------------------------------------------------------
		CONFIDENTIALITY NOTICE
		This message and its attachments are addressed solely to the persons
		above and may contain confidential information. If you have received
		the message in error, be informed that any use of the content hereof
		is prohibited. Please return it immediately to the sender and delete
		the message. Should you have any questions, please contact us by
		replying to web...@te... =
<mailto:web...@te...> .
		        Thank you
		                                        www.telecomitalia.it =
<http://www.telecomitalia.it>=20
		--------------------------------------------------------------------

--------------------------------------------------------------------

CONFIDENTIALITY NOTICE

This message and its attachments are addressed solely to the persons =
above and may contain confidential information. If you have received the =
message in error, be informed that any use of the content hereof is =
prohibited. Please return it immediately to the sender and delete the =
message. Should you have any questions, please contact us by replying to =
web...@te....

        Thank you

                                        www.telecomitalia.it

--------------------------------------------------------------------