#117 tipc_port_proto_rcv / tipc_port_recv_proto_msg error handling

[Ned Kittlitz]

in tipc_port_proto_rcv (latest version from kernel.org) and tipc_port_recv_proto_msg (3.11 kernel), I think there is an ordering problem in the error handling.

tipc_msg_init(msg, TIPC_HIGH_IMPORTANCE, TIPC_CONN_MSG,
              BASIC_H_SIZE, msg_orignode(msg));
msg_set_errcode(msg, TIPC_ERR_NO_PORT);
msg_set_origport(msg, destport);
msg_set_destport(msg, msg_origport(msg));

I think the last 2 statements should be swapped. I think this code will set msg origport and destport to the same value.

[Jon Paul Maloy]

Yes, you are right. This will have the effect that probes replies won't be accepted at
the other side. It doesn't seem to cause any problem, though (correct me if you have
experienced any such) since the unconditional probes always sent out every timer
interval, plus any traffic exchanged, will update the probing state, and compensate for
the loss.

Also, this code has been completely rewritten in 3.16, (still in net-next) and does not
have this bug, so I suggest we leave this without action.

Regards
///jon

From: Ned Kittlitz [mailto:nkittlitz@users.sf.net]
Sent: July-25-14 9:13 AM
To: Ticket 117
Subject: [tipc:bugs] #117 tipc_port_proto_rcv / tipc_port_recv_proto_msg error handling

---

[bugs:#117]http://sourceforge.net/p/tipc/bugs/117 tipc_port_proto_rcv / tipc_port_recv_proto_msg error handling

Status: open
Group:
Created: Fri Jul 25, 2014 01:13 PM UTC by Ned Kittlitz
Last Updated: Fri Jul 25, 2014 01:13 PM UTC
Owner: nobody

in tipc_port_proto_rcv (latest version from kernel.org) and tipc_port_recv_proto_msg (3.11 kernel), I think there is an ordering problem in the error handling.

tipc_msg_init(msg, TIPC_HIGH_IMPORTANCE, TIPC_CONN_MSG,

          BASIC_H_SIZE, msg_orignode(msg));

msg_set_errcode(msg, TIPC_ERR_NO_PORT);

msg_set_origport(msg, destport);

msg_set_destport(msg, msg_origport(msg));

I think the last 2 statements should be swapped. I think this code will set msg origport and destport to the same value.

---

Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/tipc/bugs/117/https://sourceforge.net/p/tipc/bugs/117

To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/https://sourceforge.net/auth/subscriptions