Re: [Timidity-devel] Fwd: patch: segment play, time-ticks skip+stop on command line

[TAMUKI S. <ta...@li...>]

Hello,

From: Yotam Medini ???? ????? <yot...@gm...>
Subject: Re: [Timidity-devel] Fwd: patch: segment play, time-ticks skip+stop on command line
Date: Fri, 17 Oct 2014 17:29:24 +0300

> Since timidity-devel@SF is CC;ed,
> I will attach a new patch 'K&R'-ed and TABed separately.
> 
> Note, that much of Timidity source code does not follow K&R and TAB use.
> 
> Personally, I do not mind K&R style, but I dislike TABs.
> The semantics of TABs leaves much to editors or browsers,
> and the resulted inconsistency is annoying.
> I consider them as unnecessary leftovers from the era of slow typewriters
> or space-bytes saving that may have been considered expensive.
> 
> But the coming patch will be as you have requested.

Thanks a lot.  You do not have to submit patches via direct to me.
You can submit patches to timidity-devel using plain text format.

> For now, I gave up on the ./autogen.sh and ./configure issue.

If you use temporarily the older autoconf and automake environment,
instead of your autoconf and automake environment, then you can use
git clone and build with success.

For example:

$ cd
$ tar xvpjf autoconf-2.59.tar.bz2
$ ( cd autoconf-2.59 ; ./configure --prefix=~ && make && make install )
$ tar xvpjf automake-1.7.6.tar.bz2
$ ( cd automake-1.7.6 ; ./configure --prefix=~ && make && make install )

After that, ~/bin, ~/share, ~/man, ~/info, and ~/lib directory are
created.  And then,

$ export PATH=~/bin:$PATH
$ ...

> As I commented, I use simple working tree extracted from the released
> TiMidity++-2.14.0.tar.bz2.
> If you would like me to try and test solution candidates, let me know.

Or, You can also use the working tree extracted from the git-hourly
tar ball which is automatically generated (up to date) and already
autoreconf'ed.

http://sourceforge.net/projects/timidity/files/TiMidity++/TiMidity++-git-hourly/

Now, I am checking your patch again.

In timidity.c, the option handling functions are sort by case-insensi-
tive alphabetical order of the short options.  The --segment option
is the second case that does not have short option.  FYI, the --module
option is the first case of that.  Besides, the --segment option does
not belong to -T option.  So, each code related to --segment option
which you add, should be move to just after the code related to
--module option.

In timidity.c, time_parse() belongs to parse_opt_segment(). So, please
exchange the order of the two functions and add the prototype of
time_parse() just after the prototype of parse_opt_segment().

Regards,
TAMUKI Shoichi