[Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[48278] branches/12.x/lib/core/Tracker/Field/ UserSelector.php

[<jon...@us...>]

Revision: 48278
          http://sourceforge.net/p/tikiwiki/code/48278
Author:   jonnybradley
Date:     2013-10-31 18:32:06 +0000 (Thu, 31 Oct 2013)
Log Message:
-----------
[FIX] trackers: Validate user really exists before storing new value. Prevents fatal error when option->notify is enabled for the field (thanks Torsten for the example, and Nelson for the diagnosis ;)

Modified Paths:
--------------
    branches/12.x/lib/core/Tracker/Field/UserSelector.php

Modified: branches/12.x/lib/core/Tracker/Field/UserSelector.php
===================================================================
--- branches/12.x/lib/core/Tracker/Field/UserSelector.php	2013-10-31 17:33:34 UTC (rev 48277)
+++ branches/12.x/lib/core/Tracker/Field/UserSelector.php	2013-10-31 18:32:06 UTC (rev 48278)
@@ -81,7 +81,13 @@
 
 		if ( isset($requestData[$ins_id])) {
 			if ($autoassign == 0 || $tiki_p_admin_trackers === 'y') {
-				$data['value'] = $requestData[$ins_id];
+				$auser = $requestData[$ins_id];
+				if (! $auser || TikiLib::lib('user')->user_exists($auser)) {
+					$data['value'] = $auser;
+				} else {
+					$data['value'] = $this->getValue();
+					TikiLib::lib('errorreport')->report(tr('User "%0" not found', $auser));
+				}
 			} else {
 				if ($autoassign == 2) {
 					$data['value'] = $user;

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.