Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[44053] branches/9.x/tiki-newsletters.php

[Jonny B. <svn...@no...>]

Ew, hard luck skinut (a.k.a..Steve C, re-welcome though! :)

I was mainly going to say well done and thanks for contributing to Tiki... all the right bits seemed to be in the right branch, and apart from a missing back port reference looked pretty good!

However, Tiki coding can be a tricky thing, as you see, but even i'm surprised at this one. Most bugs in Tiki eventually end up being a feature and so become hard to fix, hence the proliferation of preferences, many of which seem to be another "just make it work properly" option!

Sounds like this needs to be rolled back from 9.x and 10.x then, and some other way of doing it devised in trunk first (or in 10.x after 10.0 release). - hard cheeses.

It sounds to me like we need a new permission for this, which you could optionally grant to anon if needed (but i haven't looked at the code).

Meanwhile, thanks... really! :)

jonny




On 21 Nov 2012, at 09:08, Xavier de Pedro wrote:

> Skinut, could you please make this as an optional feature, please?
> Right now, after your commit, some sites will have a feature broken (I 
> have a few):
> 
> * we have subscribed email lists (mailman, in our case) for easy 
> distribution of content generated from Tiki sites (through newsletters, 
> etc), as well as many users subscribed to that newsletter. This way, any 
> users in the mailman email list will be able to cancel the subscription 
> of the email list to the tiki newsletter, and we do not want that to 
> happen. Before your commit, that was not possible, because when anyone 
> in the mailman email list clicked at the link, they were requested to 
> log in, and since they don't know the password of the fake user which 
> receives the email at the mailman email list (and receive also watches 
> of certain tiki objects thorugh gourp watches), then everything was 
> working fine.
> 
> So, please, make your feature or enhancement optional, to avoid breaking 
> current features.
> 
> Thanks and welcome back to the active developers (I did read something 
> in the irc log from these last days :-)
> 
> Xavi
> 
> On 20/11/12 22:47, sk...@us... wrote:
>> Revision: 44053
>>           http://tikiwiki.svn.sourceforge.net/tikiwiki/?rev=44053&view=rev
>> Author:   skinut
>> Date:     2012-11-20 21:47:12 +0000 (Tue, 20 Nov 2012)
>> Log Message:
>> -----------
>> [FIX] Fixed problem with newsletters requiring subscriber to be logged in to unsubscribe.
>> 
>> Modified Paths:
>> --------------
>>     branches/9.x/tiki-newsletters.php
>> 
>> Modified: branches/9.x/tiki-newsletters.php
>> ===================================================================
>> --- branches/9.x/tiki-newsletters.php	2012-11-20 21:44:52 UTC (rev 44052)
>> +++ branches/9.x/tiki-newsletters.php	2012-11-20 21:47:12 UTC (rev 44053)
>> @@ -4,12 +4,13 @@
>>  // All Rights Reserved. See copyright.txt for details and a complete list of authors.
>>  // Licensed under the GNU LESSER GENERAL PUBLIC LICENSE. See license.txt for details.
>>  // $Id$
>> -
>>  $section = 'newsletters';
>>  require_once ('tiki-setup.php');
>>  global $nllib; include_once ('lib/newsletters/nllib.php');
>>  $access->check_feature('feature_newsletters');
>> -$access->check_permission('tiki_p_list_newsletters');
>> +if ( !isset( $_REQUEST["unsubscribe"] ) ){
>> +   $access->check_permission('tiki_p_list_newsletters');
>> +}
>> 
>>  $auto_query_args = array('nlId', 'offset', 'sort_mode', 'find');
>>  $smarty->assign('confirm', 'n');
>> @@ -35,7 +36,7 @@
>>  		
>>  	}
>>  }
>> -if (!$user && $tiki_p_subscribe_newsletters != 'y' && !isset($_REQUEST["confirm_subscription"])) {
>> +if (!$user && $tiki_p_subscribe_newsletters != 'y' && !isset($_REQUEST["confirm_subscription"]) && !isset($_REQUEST["unsubscribe"])) {
>>  	$smarty->assign('msg', tra("You must be logged in to subscribe to newsletters"));
>>  	$smarty->display("error.tpl");
>>  	die;
>> 
>> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
>> 
>> 
>> ----------------
> 
> 
> ------------------------------------------------------------------------------
> Monitor your physical, virtual and cloud infrastructure from a single
> web console. Get in-depth insight into apps, servers, databases, vmware,
> SAP, cloud infrastructure, etc. Download 30-day Free Trial.
> Pricing starts from $795 for 25 servers or applications!
> http://p.sf.net/sfu/zoho_dev2dev_nov
> _______________________________________________
> Tikiwiki-cvs mailing list
> Tik...@li...
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>