Menu
▾
▴
Re: [Tiki-devel] Making the old parser just work without changing how entities are stored
|
From: Jonny B. <jo...@ti...> - 2012-04-26 17:27:05
|
I agree, gone too far to roll it all back now but too near release for a major archectural revamp so carry on patching for 9.x and let's to a webinar thing for 10. Thank you so much Robert for your tireless efforts, been there myself and agree with the dental analogy! Sorry (but only slightly ;) to have run away and have been lying about on beaches for the past fortnight :) Back online a bit tomorrow and should be actually useful sometime over the weekend... repeat after me: Tiki 9 will be fine! jonny On 26 Apr 2012, at 19:47, Robert Plummer <rob...@gm...> wrote: > I take it all back. I started migrating to a sort of semi reverted parser with encoded storage and it is like trying to re-break everything (like pulling teeth, gluing them back in, and ripping them out again). There are just too many things that are affected, wysiwyg, html purifier, code inside ckeditor, simple saving, and then the states, edit, view, and html on or off. With the code I had in before yesterday the parser worked with non-encoded html entities for the most part, wysiwyg still had a few issues, but they are very very close to being worked out, and with the converter we just need to write the rest of the scripts for converting other areas in tiki, we are about 90%-95% to the point that it is fixed. But here is the thing guys, I can't do it by myself, so either we revert everything, or I get some help writing converts and we write a migration plan down so everyone is on the same page. Can we have a quick meeting on BBB for this? > > Why the change? (I know it is ridiculous) I feel like at this point the work that has been invested (for jonny at least 2+ weeks, and me 2+ weeks) we can roll things back, but it would probably take just as much time to go forward as it would to go back. > > I'm sorry about all the confusion, I just want to get tiki 9 ready. > > On Thu, Apr 26, 2012 at 10:26 AM, Robert Plummer <rob...@gm...> wrote: > I have made quite a few changes that fix many problems in 9 and am currently working on wysiwyg, and I hope I can keep those changes in, but the migration to a new storage system is no longer feasible in 9. > > > On Thu, Apr 26, 2012 at 9:54 AM, geoff@enmore <ge...@en...> wrote: > Hi Marc - I'm sure that is the sensible approach but I'm still a bit confused by where we are with 9.x ? > > Do we have a stable/viable position now to go forward with an alpha so that we can do the final debugging in a more systematic way ? > > cheers > > geoff > > From: Marc Laporte [mailto:ma...@ma...] > Sent: 26 April 2012 14:22 > To: Tiki developers > Subject: Re: [Tiki-devel] Making the old parser just work without changing how entities are stored > > This change was done in December 2011, so it should have been enough time to fix most of the issues. > http://tikiwiki.svn.sourceforge.net/viewvc/tikiwiki?view=revision&revision=39169 > > However, it looks like not enough people were testing trunk. And I think no one predicted that it would have such an impact. > > More recently, problems were reported and several attempts to fix were made. But we clearly don't have the time and brainpower to make all the fixes this late into the release cycle. Until Robert reverted the conversion, there were basic, very visible issues on trunkdev.tiki.org and trunkdoc.tiki.org every time I checked. When something was fixed, another would pop up. And there were perhaps even more issues lurking. > > There have been maybe 20 commits on this topic and at least the same number of messages on the dev mailing list. And all this energy is taking away from the rest of the bug list. > > April 26th: we should be in RC mode. Instead, none of *.tiki.org sites have been upgraded and we have no alpha yet. (wisely, this issue was tagged as a blocker to an alpha) > > I think everyone agrees it would be better to simplify/harmonize data storage. We are now all well aware of the situation. So let's gather a team to do this in trunk, post-LTS and we can get this all cleaned up for Tiki10. > > Best regards, > > M :-) > > On Wed, Apr 25, 2012 at 4:42 PM, Filipus Klutiero <ch...@gm...> wrote: > > Hi Robert, > > > > On 2012-04-25 08:55, Robert Plummer wrote: > >> Hey guys, > >> After these issues keep popping up about the parser and how html > >> entities are stored, is it really that big of a problem to store > >> things encoded vs decoded? After jumping onto the parser, and > >> creating the framework for protecting entities till they are needed, I > >> feel we could easily change the script to account for encoded entities > >> vs decoded. There seems to be one problem after another, and I don't > >> feel that the storage is to blame, it comes back to the parser. I > >> never understood why we changed it to begin with. > > > > See http://sourceforge.net/apps/trac/tikiwiki/changeset/39206 > > There was at least one user-visible problem, displaying wiki > > differences. That only considered the encoding for one version. We could > > have hacked it, but r39206 allowed to simplify code and to clean up the > > database at the same time. > > > > For users, the source's storage format doesn't matter per se. What > > matters is the format in which the source is passed to the parser. In > > Tiki 8, wiki pages are partially source-incompatible with other > > features, i.e. the same source doesn't necessarily generate the same output. > > > >> I mean think about it, we are running into issues with storage of > >> wiki pages, wiki history, blogs, trackers, the list goes on. If we > >> "fix" this in storage, it is going to haunt us for A LONG time to > >> remain backward compatible. The fix we need (I feel) is in the > >> parser. If we can simply ensure that things are encoded correctly, > >> does anybody care how it is stored in the db? > > > > I do think we should care about the storage format. Developers need to > > have an intuitive structure. I for one can't remember the > > particularities of each of our 200+ tables, and I'm not the least > > involved developer. > > I don't really understand what you're saying about other features and > > the parser. The parser certainly needs fixing, but that's nothing new. > >> > >> > >> So my vote it to remove the conversion script all together, and make > >> the parser know better how to process entities, which it already does > >> in part, we just need to change what it is looking for, rather then > >> decoded, encoded entities. > > > > I can't see how modifying the parser could address this, unless you add > > some "compatibility" parameter or something like that. And I can't see > > how that would be a better solution than uniformizing features. > > Let's be concrete - is there an issue? If so, let's document and see > > what to do. > > > > Thanks > > > > ------------------------------------------------------------------------------ > > Live Security Virtual Conference > > Exclusive live event will cover all the ways today's security and > > threat landscape has changed and how IT managers can respond. Discussions > > will include endpoint security, mobile security and the latest in malware > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > _______________________________________________ > > TikiWiki-devel mailing list > > Tik...@li... > > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel > > > -- > Marc Laporte > > http://MarcLaporte.com > http://Tiki.org/MarcLaporte > http://AvanTech.net > > No virus found in this message. > Checked by AVG - www.avg.com > Version: 2012.0.1913 / Virus Database: 2411/4959 - Release Date: 04/25/12 > > No virus found in this message. > Checked by AVG - www.avg.com > Version: 2012.0.1913 / Virus Database: 2411/4959 - Release Date: 04/25/12 > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > TikiWiki-devel mailing list > Tik...@li... > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel > > > > > -- > Robert Plummer > > > > -- > Robert Plummer > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > TikiWiki-devel mailing list > Tik...@li... > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel |