From: Nelson Ko <ne...@wo...> - 2011-10-26 20:18:34
|
Are you sure there is functionality that prevent a preference to be enabled when its dependencies are not fulfilled? It looks to me like I am able to do so.... On Wed, Oct 26, 2011 at 10:39 AM, Filipus Klutiero <ch...@gm...> wrote: > Hi Nelson, > the default field indicates the default value if all of the preference's > dependencies are satisfied. If they aren't, the default is that the > dependant preference is disabled (otherwise, a preference could be enabled > even if its dependencies would not be satisfied). > > Le 2011-10-26 10:37, Nelson Ko a écrit : >> >> If you want (I actually think it is better) *but* then the following >> will all have to be default y as well to make sure the dependencies >> (which have always been there but not previously checked) are also on. >> >> feature_semantic >> feature_backlinks >> >> Nelson. >> >> On Wed, Oct 26, 2011 at 3:06 AM, Marc Laporte<ma...@ma...> >> wrote: >>> >>> Hi Nelson! >>> >>> Looks like changing feature_wiki_pagealias default to n is causing the >>> broken links on doc& dev upon upgrade. >>> >>> I am not sure why someone would want a page alias id it's not to redirect >>> to it. >>> >>> Can the default be yes once again? >>> >>> Thanks! >>> >>> >>> >>> On Sun, Oct 9, 2011 at 2:27 PM, Filipus Klutiero<ch...@gm...> >>> wrote: >>>> >>>> Thanks Nelson, >>>> >>>> Le 2011-09-20 17:53, nk...@us... a écrit : >>>>> >>>>> Revision: 37476 >>>>> >>>>> http://tikiwiki.svn.sourceforge.net/tikiwiki/?rev=37476&view=rev >>>>> Author: nkoth >>>>> Date: 2011-09-20 21:53:15 +0000 (Tue, 20 Sep 2011) >>>>> Log Message: >>>>> ----------- >>>>> [DOC][FIX] Make explicit the dependencies that need to be met before >>>>> page alias can work properly. I know it might be good one day to not have >>>>> these dependencies but this commit is simply to make clear what is currently >>>>> the case >>>>> >>>>> Modified Paths: >>>>> -------------- >>>>> trunk/lib/prefs/feature.php >>>>> trunk/lib/prefs/wiki.php >>>>> trunk/lib/setup/prefs.php >>>>> trunk/templates/admin/include_wiki.tpl >>>>> >>>>> Modified: trunk/lib/prefs/feature.php >>>>> =================================================================== >>>>> --- trunk/lib/prefs/feature.php 2011-09-20 21:45:03 UTC (rev >>>>> 37475) >>>>> +++ trunk/lib/prefs/feature.php 2011-09-20 21:53:15 UTC (rev >>>>> 37476) >>>>> @@ -1779,6 +1779,17 @@ >>>>> 'help' => 'Redirect+to+similar+wiki+page', >>>>> 'default' => 'n', >>>>> ), >>>>> + 'feature_wiki_pagealias' => array( >>>>> + 'name' => tra("Redirect to page alias, if >>>>> any"), >>>>> + 'type' => 'flag', >>>>> + 'description' => tra("If a requested page >>>>> doesn't exist, redirect to an alias page, if specified using an alias >>>>> semantic link"), >>>>> + 'help' => 'Page+Alias', >>>>> + 'dependencies' => array( >>>>> + 'feature_wiki_1like_redirection', >>>>> + 'feature_semantic', // this is needed at >>>>> point of creation of semantic link otherwise link will not register >>>>> + ), >>>>> + 'default' => 'n', >>>>> + ), >>>>> 'feature_wiki_templates' => array( >>>>> 'name' => tra('Wiki content templates'), >>>>> 'type' => 'flag', >>>>> >>>>> Modified: trunk/lib/prefs/wiki.php >>>>> =================================================================== >>>>> --- trunk/lib/prefs/wiki.php 2011-09-20 21:45:03 UTC (rev 37475) >>>>> +++ trunk/lib/prefs/wiki.php 2011-09-20 21:53:15 UTC (rev 37476) >>>>> @@ -622,6 +622,13 @@ >>>>> 'filter' => 'int', >>>>> 'default' => range( 1, 5 ), >>>>> ), >>>>> + 'wiki_pagealias_tokens' => array( >>>>> + 'name' => tra('Semantic link types to use as >>>>> page alias markers'), >>>>> + 'description' => tra('Comma separated list of >>>>> semantic links to use to identify a page as an alias to another'), >>>>> + 'type' => 'text', >>>>> + 'dependencies' => >>>>> array('feature_wiki_pagealias'), >>>>> + 'default' => 'alias', >>>>> + ), >>>>> 'wiki_prefixalias_tokens' => array( >>>>> 'name' => tra('Redirect pages using these >>>>> prefix alias semantic links'), >>>>> 'description' => tra('Comma separated list of >>>>> prefixes of which pages will be redirected to page with semantic link'), >>>>> >>>>> Modified: trunk/lib/setup/prefs.php >>>>> =================================================================== >>>>> --- trunk/lib/setup/prefs.php 2011-09-20 21:45:03 UTC (rev 37475) >>>>> +++ trunk/lib/setup/prefs.php 2011-09-20 21:53:15 UTC (rev 37476) >>>>> @@ -47,7 +47,7 @@ >>>>> 'backlinks_name_len' => '0', >>>>> 'feature_wiki_notepad' => 'n', >>>>> 'feature_wiki_feedback_polls' => array(), >>>>> - 'feature_wiki_pagealias' => 'y', >>>>> + 'feature_wiki_pagealias' => 'n', >>>>> 'mailin_autocheck' => 'n', >>>>> 'mailin_autocheckFreq' => '0', >>>>> 'mailin_autocheckLast' => 0, >>>>> @@ -58,6 +58,7 @@ >>>>> 'wiki_top_bar' => 'y', >>>>> 'feature_wiki_watch_structure' => 'n', >>>>> 'wiki_validate_plugin' => 'y', >>>>> + 'wiki_pagealias_tokens' => 'alias', >>>>> >>>>> // webservices >>>>> 'webservice_consume_defaultcache' => 300, // 5 min >>>>> @@ -401,4 +402,4 @@ >>>>> function isMySQLFulltextSearchSupported() { >>>>> global $tikilib; >>>>> return $tikilib->isMySQLFulltextSearchSupported(); >>>>> -} >>>>> \ No newline at end of file >>>>> +} >>>>> >>>>> Modified: trunk/templates/admin/include_wiki.tpl >>>>> =================================================================== >>>>> --- trunk/templates/admin/include_wiki.tpl 2011-09-20 21:45:03 UTC >>>>> (rev 37475) >>>>> +++ trunk/templates/admin/include_wiki.tpl 2011-09-20 21:53:15 UTC >>>>> (rev 37476) >>>>> @@ -228,6 +228,8 @@ >>>>> {preference name=wiki_likepages_samelang_only} >>>>> </div> >>>>> {preference name=feature_wiki_1like_redirection} >>>>> + {preference name=feature_wiki_pagealias} >>>>> + {preference name=wiki_pagealias_tokens} >>>>> {preference name=feature_wiki_rankings} >>>>> >>>>> {preference name=feature_wiki_structure} >>>>> >>>> Should the feature_wiki_pagealias default not be removed from >>>> lib/setup/prefs.php ? >>>> Why does the default value change from y to n? > > |