Menu
▾
▴
Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[31544] branches/proposals/6.x
|
From: Stephane C. <se...@lo...> - 2011-01-23 14:35:49
|
Le Thu, Jan 13, 2011 at 09:39:22PM +0100, Pascal Kustner écrivait : > > -1 for two main reasons. First of all, I agree with Gary, this > commit goes the wrong way on the blog list. Also, this commit is > not a backport of a commit previously done in trunk... -1 agreed with pkdille and Gary. > pkdille > > 2010/12/21 <[1]ga...@cu...> > > Hi, > Sorry to be critical, but I think the double border below each blog > listing is unattractive and not necessary. The blog list is already made > of odd and even rows with alternating colors, and it's easy to see at a > glance that now the blog title and other details are on the odd-color > row and the blog description in each case is in the following even-color > row. At most, a single-line border would be sufficient, but I think even > that isn't necessary. > I also suggest making the descriptions text-align:left with a little > indent, so they are more obviously the "child" of the line above them > (the blog name, etc.). > -- Gary > > On Mon, 20 Dec 2010 22:38:51 +0000, [2]tr...@us... wrote: > > Revision: 31544 > > > > [3]http://tikiwiki.svn.sourceforge.net/tikiwiki/?rev=31544&view=rev > > Author: trebly > > Date: 2010-12-20 22:38:50 +0000 (Mon, 20 Dec 2010) > > > > Log Message: > > ----------- > > [ENH] list_blogs : more-clear : Displays subcomment colspan full > > large table under the title data and buttons. Subcomment is > > background > > blank. Blogs are separated by bottom border double medium. This > > allows > > long subcomments not to be displayed on one narrow column. A special > > class subcomment_lblogs has been created while it is not extended to > > others lists. note : ovn-update-detail-mangement :"###" marks what is > > to be cleaned up (I will) when the whole job is ended (allows to > > check > > everything todo). > > > > Modified Paths: > > -------------- > > branches/proposals/6.x/styles/layout/layout.css > > branches/proposals/6.x/templates/tiki-list_blogs.tpl > > > > Modified: branches/proposals/6.x/styles/layout/layout.css > > =================================================================== > > --- branches/proposals/6.x/styles/layout/layout.css 2010-12-20 > > 22:15:20 UTC (rev 31543) > > +++ branches/proposals/6.x/styles/layout/layout.css 2010-12-20 > > 22:38:50 UTC (rev 31544) > > @@ -1628,6 +1628,10 @@ > > .subcomment { > > margin-left: 10px; > > } > > +.subcomment_lblogs { /* ### tested on blogs to generalize to all > > lists with comments */ > > + /* margin-left: 10px; */ > > + border-bottom:double medium ; /* ### thin; blogs are not well > > separated*/ > > +} > > > > .commentsedithelp {} > > > > > > Modified: branches/proposals/6.x/templates/tiki-list_blogs.tpl > > =================================================================== > > --- branches/proposals/6.x/templates/tiki-list_blogs.tpl 2010-12-20 > > 22:15:20 UTC (rev 31543) > > +++ branches/proposals/6.x/templates/tiki-list_blogs.tpl 2010-12-20 > > 22:38:50 UTC (rev 31544) > > @@ -1,4 +1,5 @@ > > {* $Id$ *} > > +{* [mod] trebly:B01219:->subcomment span all *} > > {title help="Blogs" admpage="blogs"}{tr}Blogs{/tr}{/title} > > > > {if $tiki_p_create_blogs eq 'y'} > > @@ -63,9 +64,9 @@ > > {if ($tiki_p_admin eq 'y') or ($listpages[changes].individual eq > > 'n') or ($listpages[changes].individual_tiki_p_read_blog eq 'y' ) } > > </a> > > {/if} > > - {if $prefs.blog_list_description eq 'y'} > > + {* {if $prefs.blog_list_description eq 'y'} > > <div > > > > class="subcomment">{$listpages[changes].description|escape|nl2br}</div> > > - {/if} > > + {/if} *} > > </td> > > {/if} > > {if $prefs.blog_list_created eq 'y'} > > @@ -124,6 +125,14 @@ > > > > </td> > > </tr> > > +{* add trebly ### *} > > +{if $prefs.blog_list_description eq 'y'} > > + <tr> > > + <td colspan="{$numbercol}"> > > + <div > > > > class="subcomment_lblogs">{$listpages[changes].description|escape|nl2br}</div> > > + </td> > > + </tr> > > +{/if} > > {sectionelse} > > <tr><td class="odd" colspan="{$numbercol}"><strong>{tr}No records > > found.{/tr}</strong></td></tr> > > {/section} > > > > > > This was sent by the SourceForge.net collaborative development > > platform, the world's largest Open Source development site. > > > > > > ------------------------------------------------------------------------------ > > Lotusphere 2011 > > Register now for Lotusphere 2011 and learn how > > to connect the dots, take your collaborative environment > > to the next level, and enter the era of Social Business. > > [4]http://p.sf.net/sfu/lotusphere-d2d > > _______________________________________________ > > Tikiwiki-cvs mailing list > > [5]Tik...@li... > > [6]https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs > ------------------------------------------------------------------------------ > Lotusphere 2011 > Register now for Lotusphere 2011 and learn how > to connect the dots, take your collaborative environment > to the next level, and enter the era of Social Business. > [7]http://p.sf.net/sfu/lotusphere-d2d > _______________________________________________ > Tikiwiki-cvs mailing list > [8]Tik...@li... > [9]https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs > > References > > 1. mailto:ga...@cu... > 2. mailto:tr...@us... > 3. http://tikiwiki.svn.sourceforge.net/tikiwiki/?rev=31544&view=rev > 4. http://p.sf.net/sfu/lotusphere-d2d > 5. mailto:Tik...@li... > 6. https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs > 7. http://p.sf.net/sfu/lotusphere-d2d > 8. mailto:Tik...@li... > 9. https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs > ------------------------------------------------------------------------------ > Protect Your Site and Customers from Malware Attacks > Learn about various malware tactics and how to avoid them. Understand > malware threats, the impact they can have on your business, and how you > can protect your company and customers by using code signing. > http://p.sf.net/sfu/oracle-sfdevnl > _______________________________________________ > Tikiwiki-cvs mailing list > Tik...@li... > https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs -- Cordialement -- Stéphane Casset LOGIDÉE sàrl Se faire plaisir d'apprendre 1a, rue Pasteur Tel : +33 388 23 69 77 ca...@lo... F-67540 OSTWALD Fax : +33 388 23 69 77 http://logidee.com |