Menu
▾
▴
Re: [Tiki-devel] Mindmap Plugin - Possible Fix
|
From: lindon <li...@ti...> - 2010-11-21 23:11:12
|
Hi Jana, I think you can just leave wikiplugin_mindmap_help() as it is for now - it can be fixed up later if needed and it's decided to backport the fix to version 3.x. In current versions, wikiplugin_mindmap_info() takes its place, so it would be good to make the changes Jonny suggests in that area. This information feeds the plugin edit pop-up window, so you can see what other changes you might want to make by looking at the edit pop-up window (e.g., capitalization, better descriptions, etc.) Don't worry about breaking something, especially since you've tested it and it seems to work for you. Worst case you just roll it back. Also, plugins are pretty self-contained, so it's usually hard for them to mess up other parts of the program. Take it from me, I am an amateur developer who had never committed before until Tiki, and they still haven't kicked me out! Seriously, one of Tiki's biggest strengths is the openness and friendliness of its developers - we welcome your contribution and are happy to help if you run into problems with it. Regards, lindon On Sun, Nov 21, 2010 at 1:36 PM, Jana Sullinger <jcy...@me...> wrote: > Ah...well the legacy function aspect, yes, makes sense. I actually couldn't > get the more current format to work. So, I am guessing I am not > understanding something there. I think I have what I had tested there before > the legacy code, by //. Can you tell me what I am doing wrong there? So, if > I want to leave legacy in, do you leave as is for 4 and above? Or if > possible, all versions of code available? Hope you get what I am asking. > > Also, I dropped the "id" and "title" . Did you review the first file I > sent, or the second? > > You do want to have the ability to have multiple maps on one page. So, I > tested that, and it appears to work. I dropped the "id" from the info area, > as I thought perhaps it was automatically generated when more than one map > inserted. Didn't check the database though to see if that was case. > > Gulp...the commit part is scary for me. First question, can I break > something really bad? and if so, be banished to "you broke Tikiwiki" > forever? > > On Nov 21, 2010, at 9:30 AM, Jonny Bradley wrote: > > > > > Hi Jana > > > > I still haven't got time to fully install and test the mindmap feature > now, but the code you sent looks good to me. A couple of minor comments... > > > > The wikiplugin_mindmap_help() is a legacy function for pre Tiki 4 (?) > use, normally you can remove these but as it's a mod and might need to go in > an old Tiki it's probably best to leave it in there. > > > > On the 'plugin' parameter you could use an 'options' array to make a > drop-down list for the choices on the plugin edit form, same for the 'mode'. > > > > The two calls to fetch_mindmap() look like they should be separated by an > else there on line 171, otherwise don't you end up with two mindmaps? (maybe > that's the idea). > > > > Generally it looks good for a start (and it works now for you, right?), > so i'd say go ahead and commit it once you have access into > https://tikiwiki.svn.sourceforge.net/svnroot/tikiwiki/mods/trunk/wiki-plugins/mindmap/wiki-pluginsand it can be fine-tuned further if needed. > > > > Well done, thanks and welcome to Tiki! :) > > > > jonny > > > > On 21 Nov 2010, at 10:16, Marc Laporte wrote: > > > >> Hi! > >> > >> If no one answers, consider as tacit assent. > >> > >> http://dev.tiki.org/Commit > >> > >> Thanks! > >> > >> M :-) > >> > >> > >>> On 2010-11-20 8:46 PM, "Jana Sullinger" <jcy...@me...> wrote: > >>> > >>> have removed the id and title from the info area. > >>> > >>> > >>> > >>> > >>> > >>> > >>> On Nov 20, 2010, at 3:09 AM, Jana Sullinger wrote: > >>> > >>>> Hello all...i think I have the Mindmap Plugin issue fixed. > >>>> > >>>> I have attached the file that I modified to test on my site, > http://cytopathnet.org. It appears that all is functioning now. The plugin > is appearing in the admin section, requires activation of feature, and the > plugin is now editable and usable from the WYSIWYG editor. I would greatly > appreciate someone verifying my changes to see if I approached this > correctly. As I have said, I am a newbie, and a hacker, so, I may not have > all the right lingo, etc. down. I added additional copyright info at top of > page, similar to that in other pages, so if this is incorrect, please let me > know how it should be. I can update the documentation, etc. as needed when > known it is functioning properly. > >>>> > >>>> Thanks! > >>>> > >>>> jcyrisse > >>>> > >>>> > >>>> > <wikiplugin_mindmap.php>------------------------------------------------------------------------------ > >>>> Beautiful is writing same markup. Internet Explorer 9 supports > >>>> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. > >>>> Spend less time writing and rewriting code and more time creating > great > >>>> experiences on the web. Be a part of the beta today > >>>> > http://p.sf.net/sfu/msIE9-sfdev2dev_______________________________________________ > >>>> TikiWiki-devel mailing list > >>>> Tik...@li... > >>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel > >>> > >>> > >>> > ------------------------------------------------------------------------------ > >>> Beautiful is writing same markup. Internet Explorer 9 supports > >>> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. > >>> Spend less time writing and rewriting code and more time creating > great > >>> experiences on the web. Be a part of the beta today > >>> http://p.sf.net/sfu/msIE9-sfdev2dev > >>> _______________________________________________ > >>> TikiWiki-devel mailing list > >>> Tik...@li... > >>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel > >>> > >> > >> > ------------------------------------------------------------------------------ > >> Beautiful is writing same markup. Internet Explorer 9 supports > >> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. > >> Spend less time writing and rewriting code and more time creating great > >> experiences on the web. Be a part of the beta today > >> > http://p.sf.net/sfu/msIE9-sfdev2dev_______________________________________________ > >> TikiWiki-devel mailing list > >> Tik...@li... > >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel > > > > > > > ------------------------------------------------------------------------------ > > Beautiful is writing same markup. Internet Explorer 9 supports > > standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. > > Spend less time writing and rewriting code and more time creating great > > experiences on the web. Be a part of the beta today > > http://p.sf.net/sfu/msIE9-sfdev2dev > > _______________________________________________ > > TikiWiki-devel mailing list > > Tik...@li... > > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel > > > > ------------------------------------------------------------------------------ > Beautiful is writing same markup. Internet Explorer 9 supports > standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. > Spend less time writing and rewriting code and more time creating great > experiences on the web. Be a part of the beta today > http://p.sf.net/sfu/msIE9-sfdev2dev > _______________________________________________ > TikiWiki-devel mailing list > Tik...@li... > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel > |