Menu
▾
▴
Re: [Tiki-devel] [Tikiwiki-devel] tiki 6 regression: icons in menuoptions
|
From: Jonny B. <jo...@ti...> - 2010-11-18 14:19:52
|
Sounds good to me, but there should a note on the menu edit page saying that you need to escape some stuff yourself? (or better, how about a button to escape it for you?)
I find the majority of validation errors on Tikis come from menus...
jb
On 18 Nov 2010, at 10:16, geoff@enmore wrote:
> Doh ! now I feel stupid since I should have seen what was happening.
>
> Anyway - thanks Changi - now I do see. I assume your change was a local patch since I don't see this update in either the 6-branch or trunk.
>
> So to restore the ability to have images (and do other stuff if needed) in the menu name field, and so that this is displayed properly in the menu admin screen for the preview and listing sections, what we should do is update 3 .tpl's:
> tiki-user_cssmenu.tpl
> tiki-admin_menu_options.tpl
> tiki-user_menu.tpl
>
> So that the |escape modifier does not encode the name field variable when displaying either a section or option menu level and this would work for both css menus and the normal menu type.
>
> In an earlier email Marc suggested that this change may have been made to enable another new facility - but I can't see what that would be? Does anyone know what this could be?
>
>
> So if no-one objects I will make these changes to the 6-branch later today/tomorrow (then the normal merge cycle can take it to trunk whilst we are in the current 6.0/6.1 stage of the release cycle)
>
> Let me know if anyone has another view.
>
> cheers
>
> geoff
>
>
> From: Jean-François BILGER [mailto:cha...@gm...]
> Sent: 18 November 2010 07:36
> To: ge...@en...; Tiki developers
> Subject: Re: [Tiki-devel] [Tikiwiki-devel] tiki 6 regression: icons in menuoptions
>
> Index: templates/tiki-user_cssmenu.tpl
> ===================================================================
> --- templates/tiki-user_cssmenu.tpl (revision 30676)
> +++ templates/tiki-user_cssmenu.tpl (working copy)
> @@ -34,7 +34,7 @@
> {capture name=chdataName}
> {if $translate eq 'n'}{$chdata.name}{else}{tr}{$chdata.name}{/tr}{/if}
> {/capture}
> - <span class="menuText">{$smarty.capture.chdataName|escape}</span>
> + <span class="menuText">{$smarty.capture.chdataName}</span>
> {if $link_on_section ne 'n'}</a>{/if}
> {assign var=opensec value=$opensec+1}
> <ul>
>
> That is what i had to do on the community website.
>
> Changi
>
> 2010/11/18 geoff@enmore <ge...@en...>
> Just to say ..
>
> I was getting img html tags to work in the name field for menu options (with
> my various workarounds) upto at least v30339 (27th Oct) so something changed
> after this.
>
> I've looked at the various .tpl's and I don’t think it’s a 'display' problem
> - I think its how the text is captured and stored where < is being converted
> to < and > is converted to > so they are no longer understood as html
> tags
>
> Can anyone think what the change might have been?
>
> Cheers
>
> geoff
>
>
>
> -----Original Message-----
> From: Stephane Casset [mailto:se...@lo...]
> Sent: 17 November 2010 13:07
> To: sgr...@gm...; Tiki developers
> Subject: Re: [Tiki-devel] [Tikiwiki-devel] tiki 6 regression: icons in
> menuoptions
>
> Le Wed, Nov 17, 2010 at 07:00:03AM -0500, Sylvie Greverend écrivait :
> > Perhaps chealer's commit 22292???
>
> Yes most probabily the templates/tiki-user_menu.tpl and
> templates/tiki-admin_menu_options.tpl part...
>
> Thanx Sylvie for identifying this commit.
>
> > On Sun, 2010-11-14 at 20:03 -0500, ga...@cu... wrote:
> > > I just realized (after svn-up) that the regression is _any_ HTML in
> > > thr menu item text is now displayed raw. I have a menu item
> > > (top-level option) that uses superscript. Now the <sup> tags show
> > > instead of work. :-/
> > >
> > > A workaround might be to use CSS background images, but this is more
> > > trouble and may not be available if the menu or theme is already
> > > using that selector.
> > >
> > > -- Gary
> > >
> > >
> > > On Sun, 14 Nov 2010 11:44:26 -0500, "Rick Sapir"
> > > <ric...@ke...> wrote:
> > > > But I want icons for specific menu *options* -- not the menu itself.
> > > >
> > > > -R
> > > >
> > > > ---
> > > > Greetings from Sanford, NC, USA!
> > > > ----- Original Message -----
> > > > From: Marc Laporte
> > > > To: Tikiwiki developers
> > > > Sent: Sunday, November 14, 2010 8:27 AM
> > > > Subject: Re: [Tikiwiki-devel] tiki 6 regression: icons in menu
> > > > options
> > > >
> > > >
> > > > This trick is error prone so I am not surprised if it breaks from
> one
> > > > version to the next.
> > > >
> > > > There is a new feature that permits icons for menus. This should be
> a
> > > > clean way to handle this.
> > > >
> > > > Did you try it?
> > > >
> > > > Best regards,
> > > >
> > > > M ;-)
> > > >
> > > >
> > > > On 2010-11-13 10:27 PM, "Rick Sapir"
> > > > <ric...@ke...>
> > > wrote:
> > > >
> > > >
> > > > Prior to TIki 6, it was possible to add an icon to any menu
> option,
> > > > simply by adding <img src="......" /> in the NAME field when
> > > > adding
> > > a
> > > > menu option.
> > > >
> > > > In Tiki 6, this seems to be broken -- sometimes. You can see this
> on
> > > > http://info.tiki.org
> > > >
> > > > - The icon for the Getting Started menu option appears, as
> expected.
> > > > - The icon for the Features > Promo Sheet menu option does *not*
> > > > render. Instead you see the HTML coding.
> > > >
> > > > Anyone know what's up or how to correct?
> > > >
> > > > -R
> > > >
>
> A+
> --
> Stéphane Casset LOGIDÉE sàrl Se faire plaisir d'apprendre
> 1a, rue Pasteur Tel : +33 388 23 69 77 ca...@lo...
> F-67540 OSTWALD Fax : +33 388 23 69 77 http://logidee.com
>
>
>
>
> _____
>
> No virus found in this message.
> Checked by AVG - www.avg.com
> Version: 10.0.1153 / Virus Database: 424/3262 - Release Date: 11/17/10
>
>
>
> ------------------------------------------------------------------------------
> Beautiful is writing same markup. Internet Explorer 9 supports
> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
> Spend less time writing and rewriting code and more time creating great
> experiences on the web. Be a part of the beta today
> http://p.sf.net/sfu/msIE9-sfdev2dev
> _______________________________________________
> TikiWiki-devel mailing list
> Tik...@li...
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>
>
>
> --
> Changi
> --
> Tiki Wiki CMS Groupware Project - Infrastructure Team - http://tikiwiki.org
>
> No virus found in this message.
> Checked by AVG - www.avg.com
> Version: 10.0.1153 / Virus Database: 424/3263 - Release Date: 11/17/10
>
> No virus found in this message.
> Checked by AVG - www.avg.com
> Version: 10.0.1153 / Virus Database: 424/3263 - Release Date: 11/17/10
>
> ------------------------------------------------------------------------------
> Beautiful is writing same markup. Internet Explorer 9 supports
> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
> Spend less time writing and rewriting code and more time creating great
> experiences on the web. Be a part of the beta today
> http://p.sf.net/sfu/msIE9-sfdev2dev_______________________________________________
> TikiWiki-devel mailing list
> Tik...@li...
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
|