Menu
▾
▴
Re: [Tikiwiki-devel] [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[29844] branches/6.x/styles/lite/lite.css
|
From: Jonny B. <jo...@ti...> - 2010-10-11 16:04:25
|
Hi Devels/CVS/SVN lists
I removed the current workaround in r29938 (ckeditor) and r29940 (normal textareas) - all seems good for me (actually quicker page loading and much less flickering now).
Obviously this is a bit of a scary change so close to release time, so can anyone who has time please try and double test this as soon as possible and feedback results good or bad here (or on irc).
Thanks - moving forwards! :)
jb
On 11 Oct 2010, at 12:38, Nyloth wrote:
> Thanx :)
>
> 2010/10/9 Jonny Bradley <jo...@ti...>
>
> Ok - agreed, will remove the workarounds ASAP, as long as everyone promises to feedback results quicky-quick!
>
> jb
>
>
>
> On 8 Oct 2010, at 13:37, Nyloth wrote:
>
> > Hi Jonny (& others),
> >
> > I tested the "comment out line 76 of block.textarea.php" suggestion
> > and this apparently works fine now (at least for me).
> > Could you also test it and if you also agree that's ok, then we can
> > remove this special FF code ?
> >
> > My opinion is that's not too late for 6.0 because it will remove a lot
> > of kludges and we will be able to release a really better code
> > (cleaner and maybe also better in terms of performance... and even
> > with less risks of javascript problems somewhere else).
> >
> > We still have a month to fix things if we find a regression / side-effect.
> >
> > So... please remove kludges / hacks if they are not needed anymore :-)
> >
> > Cheers,
> > Nyloth
> >
> >
> > 2010/10/7 Jonny Bradley <jo...@ti...>:
> >>
> >> Hi all
> >>
> >> Bit short of time today, but to test if this fixes the Firefox selection issue, the easiest way to test will be to comment out line 76 of block.textarea.php (which sets the body to display:block for ckeditor). You could do the same in tiki-js.js for the "normal" textarea but the kludges are far messier and you'd have to hit several functions.
> >>
> >> Without this, almost all the tools in there fail on Firefox (text colour etc) if body is defined as table (which you now would have to do using Firebug, or rollback r29844).
> >>
> >> Seems to work ok now for me, and Gary's commit r29859 looks ok to me too, but i never saw what the problem the display:table thing was fixing anyway.
> >>
> >> Maybe it's too late now to take out the hacks and workarounds for Fx in 6.0 - or is it? What do you think?
> >>
> >> If we try it, will people test it enough (it's quite an esoteric one)
> >>
> >> Thoughts on an email please...
> >>
> >> jonny
> >>
> >>
> >>
> >> On 7 Oct 2010, at 04:39, Nyloth wrote:
> >>
> >>> Hi Gary, Jonny & Jyhem,
> >>>
> >>> Ok, sorry, I did not saw any problems when doing tests on my laptop :-/
> >>> Too many cases to test.... :-/
> >>>
> >>> Jonny and Jyhem should be able to explain more precisely the
> >>> javascript problems.
> >>>
> >>> Thank you Gary for your proposition. If you are confident that it
> >>> works, please commit it.
> >>> I'll try to test it asap with Jyhem.
> >>>
> >>> Cheers,
> >>> Nyloth
> >>>
> >>>
> >>> 2010/10/7 <ga...@cu...>:
> >>>> Adding these rules to lite.css seems to work, to keep the column content
> >>>> from overlapping:
> >>>>
> >>>> #fixedwidth {
> >>>> display: table;
> >>>> }
> >>>>
> >>>> .fixed_width #fixedwidth {
> >>>> display: inherit;
> >>>> }
> >>>>
> >>>> The first case is when fixed width is off, when display:table is needed to
> >>>> prevent column overlap. (body has the fixedwidth class only when fixed
> >>>> width is on -- apparently the lite.css method works with either a
> >>>> specific-width div around the columns _or_ a display:table property on a
> >>>> div around the columns). I don't know how to check for the textarea and
> >>>> javascript problems, though, but I'm wondering if those problems still
> >>>> occur if display:table is a property of #fixedwidth rather than body.
> >>>>
> >>>> -- Gary
> >>>>
> >>>>
> >>>>
> >>>>
> >>>> On Wed, 06 Oct 2010 20:47:00 -0400, <ga...@cu...> wrote:
> >>>>> This change breaks the layout when fixed width is not on. As the comment
> >>>>> in lite.css says, long text strings and tables in the center column
> >>>> overlap
> >>>>> the right column rather than pushing it to the right. I checked in
> >>>> Firefox
> >>>>> and Opera so far.
> >>>>>
> >>>>> -- Gary
> >>>>>
> >>>>>
> >>>>> On Wed, 06 Oct 2010 22:08:11 +0000, ny...@us... wrote:
> >>>>>> Revision: 29844
> >>>>>>
> >>>>> http://tikiwiki.svn.sourceforge.net/tikiwiki/?rev=29844&view=rev
> >>>>>> Author: nyloth
> >>>>>> Date: 2010-10-06 22:08:11 +0000 (Wed, 06 Oct 2010)
> >>>>>>
> >>>>>> Log Message:
> >>>>>> -----------
> >>>>>> [FIX] lite.css : 'display: table' on the body is causing a lot of
> >>>>>> javascript problems / weird behaviors, especially when trying to get
> >>>>>> selection range of textareas.
> >>>>>>
> >>>>>> Modified Paths:
> >>>>>> --------------
> >>>>>> branches/6.x/styles/lite/lite.css
> >>>>>>
> >>>>>> Modified: branches/6.x/styles/lite/lite.css
> >>>>>> ===================================================================
> >>>>>> --- branches/6.x/styles/lite/lite.css 2010-10-06 21:56:26 UTC (rev
> >>>>> 29843)
> >>>>>> +++ branches/6.x/styles/lite/lite.css 2010-10-06 22:08:11 UTC (rev
> >>>>> 29844)
> >>>>>> @@ -12,7 +12,7 @@
> >>>>>> */
> >>>>>>
> >>>>>> body {
> >>>>>> - display: table;/* keep "display: table" here to push the right column
> >>>>> to
> >>>>>> the right when some unwrappable stuff appears in the center column */
> >>>>>> + display: block;
> >>>>>> font-family: sans-serif;
> >>>>>> font-size: 80%;/* the body font-size must be in percents to scale the
> >>>>>> fonts in IE properly */
> >>>>>> margin: 0; padding: 0;
> >>>>>>
> >>>>>>
> >>>>>> This was sent by the SourceForge.net collaborative development
> >>>> platform,
> >>>>>> the world's largest Open Source development site.
> >>>>>>
> >>>>>>
> >>>>>
> >>>> ------------------------------------------------------------------------------
> >>>>>> Beautiful is writing same markup. Internet Explorer 9 supports
> >>>>>> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
> >>>>>> Spend less time writing and rewriting code and more time creating
> >>>> great
> >>>>>> experiences on the web. Be a part of the beta today.
> >>>>>> http://p.sf.net/sfu/beautyoftheweb
> >>>>>> _______________________________________________
> >>>>>> Tikiwiki-cvs mailing list
> >>>>>> Tik...@li...
> >>>>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
> >>>>>
> >>>>>
> >>>> ------------------------------------------------------------------------------
> >>>>> Beautiful is writing same markup. Internet Explorer 9 supports
> >>>>> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
> >>>>> Spend less time writing and rewriting code and more time creating great
> >>>>> experiences on the web. Be a part of the beta today.
> >>>>> http://p.sf.net/sfu/beautyoftheweb
> >>>>> _______________________________________________
> >>>>> Tikiwiki-cvs mailing list
> >>>>> Tik...@li...
> >>>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
> >>>>
> >>>> ------------------------------------------------------------------------------
> >>>> Beautiful is writing same markup. Internet Explorer 9 supports
> >>>> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
> >>>> Spend less time writing and rewriting code and more time creating great
> >>>> experiences on the web. Be a part of the beta today.
> >>>> http://p.sf.net/sfu/beautyoftheweb
> >>>> _______________________________________________
> >>>> Tikiwiki-cvs mailing list
> >>>> Tik...@li...
> >>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
> >>>>
> >>
> >>
> >> ------------------------------------------------------------------------------
> >> Beautiful is writing same markup. Internet Explorer 9 supports
> >> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
> >> Spend less time writing and rewriting code and more time creating great
> >> experiences on the web. Be a part of the beta today.
> >> http://p.sf.net/sfu/beautyoftheweb
> >> _______________________________________________
> >> Tikiwiki-cvs mailing list
> >> Tik...@li...
> >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
> >>
>
>
> ------------------------------------------------------------------------------
> Beautiful is writing same markup. Internet Explorer 9 supports
> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
> Spend less time writing and rewriting code and more time creating great
> experiences on the web. Be a part of the beta today.
> http://p.sf.net/sfu/beautyoftheweb
> _______________________________________________
> Tikiwiki-cvs mailing list
> Tik...@li...
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>
|