[Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[28752] branches/5.x/tiki-sheets.php

[<oh...@us...>]

Revision: 28752
          http://tikiwiki.svn.sourceforge.net/tikiwiki/?rev=28752&view=rev
Author:   ohertel
Date:     2010-08-29 17:23:55 +0000 (Sun, 29 Aug 2010)

Log Message:
-----------
[fix] Temporary fix for tiki sheet editing. Sheets are broken for admins of sites with a large user base, because the complete user base is loaded and assigned to a variable, causing a memory error most often. Needs to get improvement.

Modified Paths:
--------------
    branches/5.x/tiki-sheets.php

Modified: branches/5.x/tiki-sheets.php
===================================================================
--- branches/5.x/tiki-sheets.php	2010-08-29 16:14:06 UTC (rev 28751)
+++ branches/5.x/tiki-sheets.php	2010-08-29 17:23:55 UTC (rev 28752)
@@ -52,7 +52,8 @@
 	// Get information about this sheetId and fill smarty variables
 	$smarty->assign('edit_mode', 'y');
 	if ($tiki_p_admin == 'y' || $tiki_p_admin_sheet == 'y') {
-		$users = $tikilib->list_users(0, -1, 'login_asc', '', false);
+		// TODO: fetch only data from user base that are really required, till then we only get 300 latest entries, cause -1 kills sheets for all site with a big user base
+		$users = $tikilib->list_users(0, 300, 'login_asc', '', false);
 		$smarty->assign_by_ref('users', $users['data']);
 	}
 	if ($_REQUEST["sheetId"] > 0) {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.