From: Jacob M. <ja...@ma...> - 2010-05-26 16:13:12
|
I've attached my proposed patch. Take a look and tell me what you think. :) I've tested it throughly, and am currently re-testing it again. In addition to that, it modifies the attachments admin interface to link back to the pages. Cheers Jacob ----- Original Message ----- From: "Stephane Casset" <se...@lo...> To: "Tikiwiki developers" <tik...@li...> Sent: Wednesday, May 26, 2010 5:50 PM Subject: Re: [Tikiwiki-devel] Tiki 5 anyone? > Le Wed, May 26, 2010 at 04:59:31PM +0200, Jacob Moen écrivait : >> The only issue I have with Tiki 5 right now is the attachments. :) >> >> I still can't see why the attachments are stored with a unicode name for >> the >> path when the images and the rest of the files are not (when they are >> stored >> in file system). All of them use plain md5 it seems. >> >> I know that the character sequence § is used for other things, but I >> don't >> agree it should be used to store the path for the attachments. >> It breaks the backup routines and is error prone on systems which doesn't >> operate in unicode by default, like my Vista installation (Danish >> locale). >> >> I'll patch that up locally, but it would be great if it could go into >> Tiki 5 >> as it's probably not something for a minor version ? >> >> Looking forward to seeing Tiki 5 :) > > Well after much thinking, but little coding I think we can go with the > patch which removes the § from the attachement names which are only used > in db and fs... > > A+ > -- > Stéphane Casset LOGIDÉE sàrl Se faire plaisir d'apprendre > 1a, rue Pasteur Tel : +33 388 23 69 77 ca...@lo... > F-67540 OSTWALD Fax : +33 388 23 69 77 http://logidee.com > > ------------------------------------------------------------------------------ > > _______________________________________________ > Tikiwiki-devel mailing list > Tik...@li... > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel > |