Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[25137] trunk/lib/tiki-js.js

[Jonny B. <jo...@ti...>]

I can't seem to reproduce this here - can anyone else shed any light on it?

Ah... how about (one mo...) Yes... no, i thought so - i took out the call to tikibas on page load/ready. I changed the templates to the html is rendered correctly according to the cookietab, so no JS to do with tabs should be running until you click something. Must be something else...

No sign of tikitab calls in edit fgals, or show()

Sorry, need more info - a filename at least?

jb

On 2 Mar 2010, at 19:16, Sylvie Greverend wrote:

> Hi Jonnyb,
> Now sometimes - mainly in FF when I edit a fgal, I have empty tabs and
> the error
> show is not defined
> This commit deletes show assuming it will be already in jquery.....
> It does not to happen in other tabs - so far I know
> Chealer reported he has the same error but it disappears.
> Any idea?
> Thx
> sylvie
> 
> On Fri, 2010-02-12 at 13:28 +0000, jon...@us...
> wrote:
>> Revision: 25137
>>          http://tikiwiki.svn.sourceforge.net/tikiwiki/?rev=25137&view=rev
>> Author:   jonnybradley
>> Date:     2010-02-12 13:28:29 +0000 (Fri, 12 Feb 2010)
>> 
>> Log Message:
>> -----------
>> [KIL] Remove tiki-js.js functions overridden in tiki-jquery.js (show, hide, flip and switchCheckboxes)
>> 
>> Modified Paths:
>> --------------
>>    trunk/lib/tiki-js.js
>> 
>> Modified: trunk/lib/tiki-js.js
>> ===================================================================
>> --- trunk/lib/tiki-js.js	2010-02-12 13:15:10 UTC (rev 25136)
>> +++ trunk/lib/tiki-js.js	2010-02-12 13:28:29 UTC (rev 25137)
>> @@ -437,28 +437,6 @@
>> }
>> 
>> 
>> -function show(foo,f,section) {
>> -	if (document.getElementById(foo)) {
>> -		document.getElementById(foo).style.display = "block";
>> -	}
>> -	if (f) {
>> -		setCookie(foo, "o", section);
>> -	}
>> -}
>> -
>> -function hide(foo,f, section) {
>> -	if (document.getElementById(foo)) {
>> -		document.getElementById(foo).style.display = "none";
>> -		if (f) {
>> -			var wasnot = getCookie(foo, section, 'x') == 'x';
>> -			setCookie(foo, "c", section);
>> -			if (wasnot) {
>> -				history.go(0);
>> -			}
>> -		}
>> -	}
>> -}
>> -
>> function flip_multi(foo,style) {
>> 	showit = 'show_' + escape(foo);
>> 
>> @@ -485,29 +463,6 @@
>> 	}
>> }
>> 
>> -function flip(foo,style) {
>> -	showit = 'show_' + escape(foo);
>> -
>> -	if (style === undefined) { style = 'block'; }
>> -	/* iewin changed to iewin7 by Enmore */	
>> -	if (this.iewin7 && style == 'table-cell') {
>> -		style = 'block';
>> -	}
>> -
>> -	if (document.getElementById(foo).style.display == "none") {
>> -		document.getElementById(foo).style.display = style;
>> -		setSessionVar(showit,'y');
>> -	} else {
>> -		if (document.getElementById(foo).style.display == style) {
>> -			document.getElementById(foo).style.display = "none";
>> -			setSessionVar(showit, 'n');
>> -		} else {
>> -			document.getElementById(foo).style.display = style;
>> -			setSessionVar(showit, 'y');
>> -		}
>> -	}
>> -}
>> -
>> function toggle(foo) {
>> 	if (document.getElementById(foo).style.display == "none") {
>> 		show(foo, true, "menu");
>> @@ -894,21 +849,6 @@
>> 	}
>> } // flipWithSign()
>> 
>> -
>> -//Check / Uncheck all Checkboxes
>> -
>> -function switchCheckboxes(tform, elements_name, state) {
>> -	// checkboxes need to have the same name elements_name
>> -  // e.g. <input type="checkbox" name="my_ename[]">, will arrive as Array in php.
>> -	for (var i = 0; i < tform.length; i++) {
>> -		if (tform.elements[i].name == elements_name) {
>> -			tform.elements[i].checked = state;
>> -		}
>> -	}
>> -	return true;
>> -}
>> -
>> -
>> //Set client timezone
>> //Added 7/25/03 by Jeremy Jongsma (jjo...@ti...)
>> //Updated 11/04/07 by Nyloth to get timezone name instead of timezone offset
>> 
>> 
>> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
>> 
>> ------------------------------------------------------------------------------
>> SOLARIS 10 is the OS for Data Centers - provides features such as DTrace,
>> Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
>> http://p.sf.net/sfu/solaris-dev2dev
>> _______________________________________________
>> Tikiwiki-cvs mailing list
>> Tik...@li...
>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
> 
> 
> 
> ------------------------------------------------------------------------------
> Download Intel&#174; Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> _______________________________________________
> Tikiwiki-cvs mailing list
> Tik...@li...
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs