Menu
▾
▴
Re: [Tikiwiki-devel] Modification proposal for Insert Image from File on TW 3.
|
From: José I. C. T. <ild...@ya...> - 2009-11-29 04:15:26
|
Hi!
Thanks for the fast answer, Marc!
Ok, I can take a look at tiki 5 trunk, but one question: hasn't there been many changes from 3.x to 5?
The problem is: the feature is currently broken on tiki 3.3, and because of the LTS thing, I believe it will be adopted by several sites (LTS is really attractive to some people).
Say, you click the insert image button, and insert a PDF (because it is listed there), it shows the PDF icon on the wiki page, but when you click the icon to open the file, it just get stuck (which is bad).
So, chatting on IRC last night, luciash said about the detection of file format, and I thought: yes, why not *detect* that it is not an image (using the file extension) and just insert the download link directly in that case, and if it is an image, just embed the image. This change would "fix" the functionality, and add what I currently need (easy way of inserting download links on wiki pages).
off course, also there is the other option, but it would be a bigger change, I think.
Thanks!
Ildefonso Camargo
--- On Sun, 11/29/09, Marc Laporte <ma...@ma...> wrote:
> From: Marc Laporte <ma...@ma...>
> Subject: Re: [Tikiwiki-devel] Modification proposal for Insert Image from File on TW 3.
> To: "Tikiwiki developers" <tik...@li...>
> Date: Sunday, November 29, 2009, 12:06 AM
> check Tiki trunk (future 5.x) because
> some work was done there.
>
> Perhaps your proposed changes are still valid, but maybe
> they need adjustment.
>
> Thanks!
>
>
> 2009/11/28 José Ildefonso Camargo Tolosa <ild...@ya...>:
> > Hi!
> >
> > I'm working on a patch to modify the "Add Image from
> File Gallery" in the wikieditor, so that it give an option
> to include the file as an [URL|text] kind of link (for
> download) instead of the file inline, or the download link
> as an icon.
> >
> > The reason: it is complicated to add a download link
> to a file stored on the file gallery to a wiki page.
> >
> > At first, I thought about adding a new button like
> "Add Download link from File Gallery", but I thought it
> would be easier to modify the existing one.
> >
> > So, I started to analyze, and finally found all of the
> pieces that insert the {img ...} thing, so.... now my
> question:
> >
> > I ended with this funcion on tiki-js.js, line 1001 on
> tiki 3 proposed:
> >
> > function SetMyUrl(area,url) {
> > var myurl = url.replace(/.*\/([^\/]*)$/,
> '$1'); /* make relative path from the absolute url */
> > str = "{img src=\""+myurl.replace(/display$/,
> 'thumbnail')+"\" alt=\"\" link=\""+myurl+"\"
> rel=\"shadowbox[g];type=img\"} ";
> > insertAt(area, str);
> > }
> >
> > And it generates the img thing, now, I want to make a
> conditional, but how to do it, I was thinking on a couple of
> ideas:
> >
> > + Due that displaying the file when it is not and
> image (say, a PDF) doesn't work (just stay the circle
> spinning with the cancel link), I think that what luciash
> (from irc channel) said could make sense: just modify the
> existing script to "detect", when it is not an image, just
> insert a donwload link, like
> ["tiki-download_file.php?fileId=27"|file_name_here] would be
> nice.
> > + Add a new button that insert a download link,
> instead of embed an image, and fix the image insert thing to
> not list non-image objects.
> >
> > What do you think?
> >
> > Sincerely,
> >
> > Ildefonso Camargo
> >
> >
> >
> >
> >
> >
> >
> ------------------------------------------------------------------------------
> > Let Crystal Reports handle the reporting - Free
> Crystal Reports 2008 30-Day
> > trial. Simplify your report design, integration and
> deployment - and focus on
> > what you do best, core application coding. Discover
> what's new with
> > Crystal Reports now. http://p.sf.net/sfu/bobj-july
> > _______________________________________________
> > Tikiwiki-devel mailing list
> > Tik...@li...
> > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
> >
>
>
>
> --
> Marc Laporte
>
> http://MarcLaporte.com
> http://TikiWiki.org/MarcLaporte
> http://AvanTech.net
> http://OurWiki.net
>
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal
> Reports 2008 30-Day
> trial. Simplify your report design, integration and
> deployment - and focus on
> what you do best, core application coding. Discover what's
> new with
> Crystal Reports now. http://p.sf.net/sfu/bobj-july
> _______________________________________________
> Tikiwiki-devel mailing list
> Tik...@li...
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>
|