From: Jonny B. <tw...@no...> - 2009-11-22 14:56:25
|
Is it right to do this in a minor release? I agree with the behaviour change in principle (best not to give out remove perms unintentionally) and the fix looks good, but it may catch people out who have managed to set up usable 3.x category perms systems (i've heard it is possible ;) +1 with the hope that the release notes can make this change clear. On 22 Nov 2009, at 12:38, sy...@us... wrote: > Revision: 23426 > http://tikiwiki.svn.sourceforge.net/tikiwiki/?rev=23426&view=rev > Author: sylvieg > Date: 2009-11-22 12:38:05 +0000 (Sun, 22 Nov 2009) > > Log Message: > ----------- > [bp/r 23254][FIX]categ perm: some people found intrusive that an > edit_categorized was able to remove a wiki page-> the perm will have > to be added manually > > Modified Paths: > -------------- > branches/proposed/lib/tikilib.php > > Modified: branches/proposed/lib/tikilib.php > =================================================================== > --- branches/proposed/lib/tikilib.php 2009-11-22 12:07:25 UTC (rev > 23425) > +++ branches/proposed/lib/tikilib.php 2009-11-22 12:38:05 UTC (rev > 23426) > @@ -4478,7 +4478,7 @@ > } > if ($categPerms['tiki_p_edit_categorized'] == 'y' || > $categPerms['tiki_p_admin_categories'] == 'y') { > $ret['tiki_p_edit'] = 'y'; > - $ret['tiki_p_remove'] = 'y'; > + $ret['tiki_p_remove'] = 'n'; > $ret['tiki_p_wiki_attach_files'] = 'y'; > } else { > $ret['tiki_p_edit'] = 'n'; > > > This was sent by the SourceForge.net collaborative development > platform, the world's largest Open Source development site. > > ------------------------------------------------------------------------------ > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 > 30-Day > trial. Simplify your report design, integration and deployment - and > focus on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > _______________________________________________ > Tikiwiki-cvs mailing list > Tik...@li... > https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs |