From: Pascal K. <pas...@gm...> - 2009-09-08 21:37:25
|
Hello, Could we just discuss here about the commit in proposed ? Trunk, as it is tabified, is (IMHO) different, and I'm open to have another discussion for trunk. But, I still do not understand. Is there a problem for proposed ? I do not see twice "create newsletter". FYI, I do not have the attached gif. Thanks, pkdille 2009/9/8 Sylvie Greverend <sgr...@gm...> > I still do not get it , sorry > What is the purpose to have twice create newsletter. See attached gif. > It is a trunk. > For trunk the link should be #contentxxx (sorry, I never remember the > syntax) > I think it is a good idea to display it - only when you are editing a > existing newsletter. > {if $nlId}{button...} > > > > > On Tue, 2009-09-08 at 17:29 +0200, Pascal Kustner wrote: > > Hello Sylvie, > > > > 1. With this change, the 'Create Newsletter' button is only displayed > > on the admin newsletter page. > > It is always displayed on this page (for newsletters listing and > > newsletter edition). > > I thought it should be enough ( or what do you suggest instead ? ) > > > > 2. These pages are not "tabified" in proposed. But, yes, in tiki4, we > > have to think twice about the how to navigate between the tabs. > > > > I hope this answers will be ok for your "+1" ;-) > > > > Regards, > > pkdille > > > > 2009/9/8 Sylvie Greverend <sgr...@gm...> > > > > 1/ Should the 'Create newsletter be only done if a newsletter > > is edited > > 2/ should it goes an the second tab > > Thx > > > > > > On Thu, 2009-09-03 at 14:09 +0000, > > pk...@us... wrote: > > > Revision: 21236 > > > > > http://tikiwiki.svn.sourceforge.net/tikiwiki/?rev=21236&view=rev > > > Author: pkdille > > > Date: 2009-09-03 14:09:07 +0000 (Thu, 03 Sep 2009) > > > > > > Log Message: > > > ----------- > > > [bp/r21234][FIX] admin newsletters: give a more intuitive > > way to switch between admin_newsletters and > > admin_newsletters_subscriptions (it was very difficult to > > create a new newsletter instead of editing the current one) > > > > > > Modified Paths: > > > -------------- > > > > > > branches/proposed/templates/tiki-admin_newsletter_subscriptions.tpl > > > branches/proposed/templates/tiki-admin_newsletters.tpl > > > > > > Modified: > > > branches/proposed/templates/tiki-admin_newsletter_subscriptions.tpl > > > > > > =================================================================== > > > --- > > > branches/proposed/templates/tiki-admin_newsletter_subscriptions.tpl > 2009-09-03 14:07:46 UTC (rev 21235) > > > +++ > > > branches/proposed/templates/tiki-admin_newsletter_subscriptions.tpl > 2009-09-03 14:09:07 UTC (rev 21236) > > > @@ -5,7 +5,8 @@ > > > <div class="navbar"> > > > {button href="tiki-newsletters.php" _text="{tr}List > > Newsletters{/tr}"} > > > {assign var="nlid_encod" value=$nlId|urlencode} > > > - {button href="tiki-admin_newsletters.php?nlId= > > $nlid_encod" _text="{tr}Admin Newsletters{/tr}"} > > > + {button href="tiki-admin_newsletters.php?nlId= > > $nlid_encod" _text="{tr}Edit Newsletter{/tr}"} > > > + {button href="tiki-admin_newsletters.php" > > _text="{tr}Admin Newsletters{/tr}"} > > > {button href="tiki-send_newsletters.php?nlId= > > $nlid_encod" _text="{tr}Send Newsletters{/tr}"} > > > </div> > > > > > > > > > Modified: > > branches/proposed/templates/tiki-admin_newsletters.tpl > > > > > > =================================================================== > > > --- branches/proposed/templates/tiki-admin_newsletters.tpl > > 2009-09-03 14:07:46 UTC (rev 21235) > > > +++ branches/proposed/templates/tiki-admin_newsletters.tpl > > 2009-09-03 14:09:07 UTC (rev 21236) > > > @@ -2,6 +2,7 @@ > > > {title help="Newsletters"}{tr}Admin > > newsletters{/tr}{/title} > > > > > > <div class="navbar"> > > > + {button href="tiki-admin_newsletters.php" > > _text="{tr}Create Newsletter{/tr}"} > > > {button href="tiki-newsletters.php" _text="{tr}List > > Newsletters{/tr}"} > > > {button href="tiki-send_newsletters.php" > > _text="{tr}Send Newsletters{/tr}"} > > > </div> > > > > > > > > > This was sent by the SourceForge.net collaborative > > development platform, the world's largest Open Source > > development site. > > > > > > > > > ------------------------------------------------------------------------------ > > > Let Crystal Reports handle the reporting - Free Crystal > > Reports 2008 30-Day > > > trial. Simplify your report design, integration and > > deployment - and focus on > > > what you do best, core application coding. Discover what's > > new with > > > Crystal Reports now. http://p.sf.net/sfu/bobj-july > > > _______________________________________________ > > > Tikiwiki-cvs mailing list > > > Tik...@li... > > > https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs > > > > > > > ------------------------------------------------------------------------------ > > Let Crystal Reports handle the reporting - Free Crystal > > Reports 2008 30-Day > > trial. Simplify your report design, integration and deployment > > - and focus on > > what you do best, core application coding. Discover what's new > > with > > Crystal Reports now. http://p.sf.net/sfu/bobj-july > > _______________________________________________ > > Tikiwiki-cvs mailing list > > Tik...@li... > > https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs > > > > > > |