Menu
▾
▴
Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[21048] branches/proposed/lib/wiki-plugins/ wikiplugin_tracker.php
|
From: Sylvie G. <sgr...@gm...> - 2009-09-08 21:17:36
|
+1 Thx for the explantion luciash On Tue, 2009-09-08 at 14:53 +0200, luci aka luciash d' being wrote: > hi sylvie, > > i don't understand... what is the default behavior then ? > i just made it the same as for non-pretty tracker (i belive) to mark the > mandatory fields... > i found it usability fix... if admin wants to highlight mandatory fields > his own way in pretty tracker template, he just can disable it by > showmandatory="n", no ? > > luci > > > On 09/08/2009 02:20 PM, Sylvie Greverend wrote: > > Euh... this one will change the default behavior. > > If this kind of change is wanted - better to limit it to major release - > > wwhere we have documentation about what to change > > My 2 cents > > > > On Sat, 2009-08-22 at 20:36 +0000, lu...@us... wrote: > > > >> Revision: 21048 > >> http://tikiwiki.svn.sourceforge.net/tikiwiki/?rev=21048&view=rev > >> Author: luciash > >> Date: 2009-08-22 20:36:12 +0000 (Sat, 22 Aug 2009) > >> > >> Log Message: > >> ----------- > >> [bp/r20365][FIX] wikiplugin_tracker (pretty tracker) input: when there is no showmandatory=n param, mark mandatory fields and display the notice (same as for non-wiki/tpl tracker input) > >> > >> Modified Paths: > >> -------------- > >> branches/proposed/lib/wiki-plugins/wikiplugin_tracker.php > >> > >> Modified: branches/proposed/lib/wiki-plugins/wikiplugin_tracker.php > >> =================================================================== > >> --- branches/proposed/lib/wiki-plugins/wikiplugin_tracker.php 2009-08-22 17:18:56 UTC (rev 21047) > >> +++ branches/proposed/lib/wiki-plugins/wikiplugin_tracker.php 2009-08-22 20:36:12 UTC (rev 21048) > >> @@ -757,8 +757,12 @@ > >> } > >> if (in_array($f['fieldId'],$outf)) { > >> > >> + if ($showmandatory == 'y' and $f['isMandatory'] == 'y') { > >> + $onemandatory = true; > >> + } > >> if (!empty($tpl) || !empty($wiki)) { > >> $smarty->assign_by_ref('field_value', $f); > >> + $smarty->assign('showmandatory', $showmandatory); > >> $smarty->assign('f_'.$f['fieldId'], $smarty->fetch('tracker_item_field_input.tpl')); > >> } else { > >> if (in_array($f['fieldId'], $optional)) { > >> @@ -772,7 +776,6 @@ > >> $back .= ">".wikiplugin_tracker_name($f['fieldId'], $f['name'], $field_errors); > >> if ($showmandatory == 'y' and $f['isMandatory'] == 'y') { > >> $back.= " <strong class='mandatory_star'>*</strong> "; > >> - $onemandatory = true; > >> } > >> $back.= "</td><td>"; > >> } else { > >> > >> > >> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. > >> > >> ------------------------------------------------------------------------------ > >> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day > >> trial. Simplify your report design, integration and deployment - and focus on > >> what you do best, core application coding. Discover what's new with > >> Crystal Reports now. http://p.sf.net/sfu/bobj-july > >> _______________________________________________ > >> Tikiwiki-cvs mailing list > >> Tik...@li... > >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs > >> > > > > > > ------------------------------------------------------------------------------ > > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day > > trial. Simplify your report design, integration and deployment - and focus on > > what you do best, core application coding. Discover what's new with > > Crystal Reports now. http://p.sf.net/sfu/bobj-july > > _______________________________________________ > > Tikiwiki-cvs mailing list > > Tik...@li... > > https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs > > > > ------------------------------------------- > > Modern Hosting PIPNI - http://www.pipni.cz/ > > > > |