[Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[14052] trunk/lib/tiki-js.js

[<lph...@us...>]

Revision: 14052
          http://tikiwiki.svn.sourceforge.net/tikiwiki/?rev=14052&view=rev
Author:   lphuberdeau
Date:     2008-08-04 20:06:07 +0000 (Mon, 04 Aug 2008)

Log Message:
-----------
[FIX] Plugin UI would behave in strange ways if no parameters were defined

Modified Paths:
--------------
    trunk/lib/tiki-js.js

Modified: trunk/lib/tiki-js.js
===================================================================
--- trunk/lib/tiki-js.js	2008-08-04 19:56:16 UTC (rev 14051)
+++ trunk/lib/tiki-js.js	2008-08-04 20:06:07 UTC (rev 14052)
@@ -1287,12 +1287,15 @@
 		var meta = tiki_plugins[type];
 		var params = [];
 
-		for( var k in meta.params )
+		if( meta.params.length )
 		{
-			var val = form['params[' + k + ']'].value;
+			for( var k in meta.params )
+			{
+				var val = form['params[' + k + ']'].value;
 
-			if( val != '' )
-				params.push( k + '=>"' + val + '"' );
+				if( val != '' )
+					params.push( k + '=>"' + val + '"' );
+			}
 		}
 
 		var blob = '{' + type.toUpperCase() + '(' + params.join(',') + ')}' + form.content.value + '{' + type.toUpperCase() + '}';
@@ -1349,32 +1352,38 @@
 	table.className = 'normal';
 	form.appendChild( table );
 
-	for( i in meta.params )
+	if( meta.params.length )
 	{
-		var row = document.createElement( 'tr' );
-		var label = document.createElement( 'td' );
-		var field = document.createElement( 'td' );
-		row.className = 'formcolor';
+		for( i in meta.params )
+		{
+			if( ! meta.params[i] )
+				continue;
 
-		label.innerHTML = meta.params[i].name;
-		if( meta.params[i].required )
-			label.style.fontWeight = 'bold';
+			var row = document.createElement( 'tr' );
+			var label = document.createElement( 'td' );
+			var field = document.createElement( 'td' );
+			row.className = 'formcolor';
 
-		var input = document.createElement( 'input' );
-		input.type = 'text';
-		input.name = 'params[' + i + ']';
-		if( args[i] )
-			input.value = args[i];
+			label.innerHTML = meta.params[i].name;
+			if( meta.params[i].required )
+				label.style.fontWeight = 'bold';
 
-		var desc = document.createElement( 'div' );
-		desc.style.fontSize = 'x-small';
-		desc.innerHTML = meta.params[i].description;
+			var input = document.createElement( 'input' );
+			input.type = 'text';
+			input.name = 'params[' + i + ']';
+			if( args[i] )
+				input.value = args[i];
 
-		field.appendChild( input );
-		field.appendChild( desc );
-		row.appendChild( label );
-		row.appendChild( field );
-		table.appendChild( row );
+			var desc = document.createElement( 'div' );
+			desc.style.fontSize = 'x-small';
+			desc.innerHTML = meta.params[i].description;
+
+			field.appendChild( input );
+			field.appendChild( desc );
+			row.appendChild( label );
+			row.appendChild( field );
+			table.appendChild( row );
+		}
 	}
 
 	var bodyRow = document.createElement( 'tr' );


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.