Re: [Threedsia-dev] CVS-Update

[Marc H. <Ax...@cu...>]

On Fri, 18 Feb 2000, you wrote:
> I'm taking a quick look at this new src now...
> ... I really like the concept of this Skelleton directory 'cause I think it
> wwill make project managment and contributions easier.

That's why I introduced it :-) When the source becomes really large and we have
have to add a fancy new feature, it is necessary to work out a good code
concept (API), before actually writing it (or discussing how an already written
part can be improved)

> CLIENT:
> [sm@kor 3Dsia]$ less client/Make.log
> client.cpp: In function `int main(int, char **)':
> client.cpp:32: warning: unused variable `int i'

OK, no problems

> 
> SERVER:
> [sm@kor 3Dsia]$ less server/Make.log
> main.cpp: In function `int main(int, char **)':
> main.cpp:43: warning: ANSI C++ forbids implicit conversion from `void *' in
> argument passing
> main.cpp:44: warning: ANSI C++ forbids implicit conversion from `void *' in
> argument passing
> main.cpp:45: warning: ANSI C++ forbids implicit conversion from `void *' in
> argument passing

ANSI C++ doesn't like function ((void*) something);
We'll have to fix this in the future:

void* someelse = (void*) something;
function (someelse)

But I was too lazy ;-)

> frontEnd.cpp: In method `FrontEnd::FrontEnd(int, char **)':
> frontEnd.cpp:20: warning: unused parameter `int argc'
> frontEnd.cpp:20: warning: unused parameter `char ** argv'
> frontEnd.cpp: In method `void FrontEnd::displayUsers(int)':
> frontEnd.cpp:32: warning: unused parameter `int users'
> frontEnd.cpp: In method `void FrontEnd::displayMatrices(int)':
> frontEnd.cpp:35: warning: unused parameter `int matrices'
> frontEnd.cpp: In method `void FrontEnd::displayDebugMessage(char *)':
> frontEnd.cpp:38: warning: unused parameter `char * msg'

Normal because of empty functions

> clientControlThread.cpp: In function `void ClientControlThread(struct
> CCTArgs *)':
> clientControlThread.cpp:124: warning: ANSI C++ forbids implicit conversion
> from `void *' in argument passing

see above

> clientControlThread.cpp:46: warning: unused parameter `struct CCTArgs *
> args'
> matrixControlThread.cpp: In function `void MatrixControlThread(struct
> MCTArgs *)':
> matrixControlThread.cpp:39: warning: unused parameter `struct MCTArgs *
> args'
> clientThread.cpp: In function `void ClientThread(struct CTArgs *)':
> clientThread.cpp:72: warning: ANSI C++ forbids implicit conversion from
> `void *' in argument passing
> clientThread.cpp:76: warning: ANSI C++ forbids implicit conversion from
> `void *' in argument passing
> communication.cpp: In function `bool Handshake(class Buffer *, class Buffer
> *, struct packet *)':
> communication.cpp:121: warning: unused parameter `class Buffer * in'
> communication.cpp: In function `bool Authenticate(class Buffer *, class
> Buffer *, struct packet *)':
> communication.cpp:149: warning: unused parameter `class Buffer * in'
> communication.cpp:149: warning: unused parameter `class Buffer * out'
> ../common/symbolTable.cpp: In method `bool SymbolTable::addData(int, char *,
> sstruct data *)':
> ../common/symbolTable.cpp:480: warning: unused variable `class FrontEnd *
> ffrontEnd'

Everythings fine, no real problems but programming suggestions ;-)
	Marc
--
Marc Haisenko
alias StonedBones
alias Axl

E-Mail: Ax...@cu...