[tcobrowser-cvs] SF.net SVN: tcobrowser:[1320] trunk/bibdesk/BibDocument_Groups.m

[<ama...@us...>]

Revision: 1320
          http://tcobrowser.svn.sourceforge.net/tcobrowser/?rev=1320&view=rev
Author:   amaxwell
Date:     2009-04-11 05:42:26 +0000 (Sat, 11 Apr 2009)

Log Message:
-----------
Do a more complete update in updateCategoryGroupsPreservingSelection:, so the library group count/content gets updated.

Modified Paths:
--------------
    trunk/bibdesk/BibDocument_Groups.m

Modified: trunk/bibdesk/BibDocument_Groups.m
===================================================================
--- trunk/bibdesk/BibDocument_Groups.m	2009-04-11 05:09:55 UTC (rev 1319)
+++ trunk/bibdesk/BibDocument_Groups.m	2009-04-11 05:42:26 UTC (rev 1320)
@@ -515,14 +515,11 @@
  category groups are visible.
  */
 - (void)updateCategoryGroupsPreservingSelection:(BOOL)preserve{
-    
-    // !!! early return if not expanded in outline view
-    if ([[groups categoryGroups] count] && [self hasCategoryGroupsExpanded] == NO) {
-        [self displaySelectedGroups];
-        return;
-    }
 
-    // this is a hack to keep us from getting selection change notifications while sorting (which updates the TeX and attributed text previews)
+    /*
+     This is a hack to keep us from getting selection change notifications 
+     while sorting (which updates the TeX and attributed text previews).
+     */
     id groupTableDelegate = [groupOutlineView delegate];
     [groupOutlineView setDelegate:nil];
     
@@ -536,7 +533,9 @@
         
         [groups setCategoryGroups:[NSArray array]];
         
-    } else {
+    }
+    // don't bother with this unless the groups are visible
+    else if ([[groups categoryGroups] count] && [self hasCategoryGroupsExpanded]) {
         
         BDSKCountedSet *countedSet;
         if([groupField isPersonField])
@@ -600,7 +599,11 @@
     
 	[self displaySelectedGroups]; // the selection may not have changed, so we won't get this from the notification
     
-    // The search: in displaySelectedGroups will change the main table's scroll location, which isn't necessarily what we want (say when clicking the add button for a search group pub).  If we selected the same groups as previously, we should scroll to the old location instead of centering.
+    /*
+     The search: in displaySelectedGroups will change the main table's scroll location, which isn't 
+     necessarily what we want (say when clicking the add button for a search group pub).  If we 
+     selected the same groups as previously, we should scroll to the old location instead of centering.
+     */
     if (didSelect)
         [[tableView enclosingScrollView] setScrollPositionAsPercentage:scrollPoint];
     


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.