[tcobrowser-cvs] SF.net SVN: tcobrowser:[1116] trunk/bibdesk/BibDocument_Groups.m

[<ama...@us...>]

Revision: 1116
          http://tcobrowser.svn.sourceforge.net/tcobrowser/?rev=1116&view=rev
Author:   amaxwell
Date:     2009-03-12 16:33:33 +0000 (Thu, 12 Mar 2009)

Log Message:
-----------
Get rid of a spurious call to -publications, which triggered a double group load for URL and script groups.  In the case of a script group which executes quickly and fails, this caused a duplicate failure dialog.

Modified Paths:
--------------
    trunk/bibdesk/BibDocument_Groups.m

Modified: trunk/bibdesk/BibDocument_Groups.m
===================================================================
--- trunk/bibdesk/BibDocument_Groups.m	2009-03-12 05:23:21 UTC (rev 1115)
+++ trunk/bibdesk/BibDocument_Groups.m	2009-03-12 16:33:33 UTC (rev 1116)
@@ -1081,8 +1081,8 @@
         unsigned int insertIndex = NSMaxRange([groups rangeOfURLGroups]);
         BDSKURLGroup *group = [sheetController group];
 		[groups addURLGroup:group];
-        [group publications];
         
+        // triggers a call to -publications, which will cause the group to start downloading
 		[groupTableView selectRowIndexes:[NSIndexSet indexSetWithIndex:insertIndex] byExtendingSelection:NO];
 		[groupTableView editColumn:0 row:insertIndex withEvent:nil select:YES];
 		[[self undoManager] setActionName:NSLocalizedString(@"Add External File Group", @"Undo action name")];
@@ -1104,8 +1104,8 @@
         unsigned int insertIndex = NSMaxRange([groups rangeOfScriptGroups]);
         BDSKScriptGroup *group = [sheetController group];
 		[groups addScriptGroup:group];
-        [group publications];
         
+        // triggers a call to -publications, which will cause the group to run its script
 		[groupTableView selectRowIndexes:[NSIndexSet indexSetWithIndex:insertIndex] byExtendingSelection:NO];
 		[groupTableView editColumn:0 row:insertIndex withEvent:nil select:YES];
 		[[self undoManager] setActionName:NSLocalizedString(@"Add Script Group", @"Undo action name")];


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.