From: Jim I. <ji...@ap...> - 2003-09-25 17:17:05
|
Benny, Thanks for looking into this. Your change looks right to me, the=20 TkWmStackorderToplevel command wants a WindowRef, not a GrafPort for=20 the hash key. Daniel added the MacOS X implementation of the=20 stackorder command, however, so we should make sure with him that this=20= is a simple goof, and there isn't something deeper here. If he agrees, then please do check it in. You have check-in permission=20= for the repository, don't you? And yes, it looks like TkWmStackorderToplevelWrapperMap should be=20 static. Jim On Sep 25, 2003, at 6:08 AM, Benjamin Riefenstahl wrote: > Hi Fran=E7ois, all, > > > Benjamin Riefenstahl <Ben...@ep...> writes: >> Running under a debugger shows that the crash is caused by the >> panic() in macosx/tkMacOSXWm.c, line 5505. > > The problem is fixed here by the attached patch. Jim, this is your > code, ok to apply? > > Fran=E7ois, if you can compile your own Tk, it would be nice if you > could try this patch to verify that there is no other issue. > > BTW, Jim, shouldn't TkWmStackorderToplevelWrapperMap() be static? It > is static in the other ports (even Mac Classic), and it is never used > outside of its own source unit. > > > benny > > <patch> -- Jim Ingham ji...@ap... Developer Tools Apple Computer |