From: Jim I. <ji...@ap...> - 2003-02-24 19:29:29
|
Benny, I checked in the bug fix to 8.2.4 - thanks for finding this. I think on the "we are really supposed to be in code slush for 8.2.4" principle, I am going to hold off on checking in the other fixes. They are all good, and by the way thanks for looking to the testsuite, that is a hole in the port that has been bugging me for a while!!! But I think they won't affect the quality of 8.4.2. Sound okay? Jim On Sunday, February 23, 2003, at 11:47 AM, Benjamin Riefenstahl wrote: > Hi Vince, all, > > I tried to make the test suite work. My first goal was to get through > it without crashing. This uncovered a real bug in tkMacOSXDialog.c. > > I also patched some functions in tkMacOSXXStubs.c to avoid other > crashes, but those functions are of course todos anyway. > > so long, benny > > > 2003-02-23 Benjamin Riefenstahl <Ben...@ep...> > > * tkMacOSXDialog.c (NavServicesGetFile): Fix bug with > kNavCtlSetSelection. > * (NavServicesGetFile): Avoid compiler warning. > * (OpenEventProc): Ditto. > > * tkMacOSXXStubs.c (XGetGeometry): Set return parameters to avoid > crashes in the test suite. > * (XSelectInput): Ditto. > * (XGetWindowProperty): Ditto. > * (XDeleteProperty): Add. > > <tkMacOSXDialog.c.diff><tkMacOSXXStubs.c.diff> -- Jim Ingham ji...@ap... Developer Tools Apple Computer |