[TCLCORE] Patch for Thread module problems.

[Mo D. <md...@cy...>]

I created this patch that fixes a couple of problems in the
current Thread module, but I am not sure where I should
send it. The "core" list seemed like a good place, so
here goes. If this module has already been moved to
sourceforge, please let me know and I will get a
newer CVS diff from there (if it matters).

What do you think, is it ok to check in?
(if I need to do that on SF, please let me know).

Mo DeJong
Red Hat Inc

Index: ChangeLog
===================================================================
RCS file: /home/cvs/external/thread/ChangeLog,v
retrieving revision 1.28
diff -u -r1.28 ChangeLog
--- ChangeLog	2000/10/16 21:18:23	1.28
+++ ChangeLog	2000/10/21 11:41:33
@@ -1,3 +1,11 @@
+2000-10-21  Mo DeJong <md...@re...>
+
+	* Makefile.in: Added code to "make test" so
+	it could be run when buildir != srcdir.
+	* tests/thread.test: Added conditional
+	code to check for commands that are
+	only support in Tcl 8.4.
+
 2000-10-16  Zoran Vasiljevic <zo...@mu...>
 
 	* generic/threadSvCmd.c ThreadSvUnsetObjCmd(): deadlocked.
Index: Makefile.in
===================================================================
RCS file: /home/cvs/external/thread/Makefile.in,v
retrieving revision 1.5
diff -u -r1.5 Makefile.in
--- Makefile.in	2000/07/03 18:47:58	1.5
+++ Makefile.in	2000/10/21 11:41:33
@@ -252,6 +252,9 @@
 	    done
 
 test:
+	@mkdir -p thread
+	@cp pkgIndex.tcl thread
+	TCLLIBPATH=`pwd`/thread \
 	$(TCLSH_PROG) $(srcdir)/tests/thread.test
 
 depend:
Index: tests/thread.test
===================================================================
RCS file: /home/cvs/external/thread/tests/thread.test,v
retrieving revision 1.8
diff -u -r1.8 thread.test
--- thread.test	2000/05/18 20:20:36	1.8
+++ thread.test	2000/10/21 11:41:33
@@ -55,9 +55,19 @@
 # Make sure this value is correct, now that we've loaded the test module
 set tcltest::mainThread [thread::id]
 
+set 84_commands {::thread::cond ::thread::create ::thread::errorproc 
::thread::exists ::thread::exit ::thread::id ::thread::join 
::thread::mutex ::thread::names ::thread::send ::thread::sv_append 
::thread::sv_array ::thread::sv_exists ::thread::sv_get ::thread::sv_incr 
::thread::sv_lappend ::thread::sv_set ::thread::sv_unset 
::thread::transfer ::thread::wait}
+
+set 83_commands {::thread::create ::thread::errorproc ::thread::exit 
::thread::id ::thread::join ::thread::names ::thread::send 
::thread::transfer ::thread::wait}
+
+if {[info tclversion] > 8.3} {
+    set commands $84_commands
+} else {
+    set commands $83_commands
+}
+
 test thread-1.2 {thread subcommands} {
     lsort [info commands thread::*]
-} {::thread::create ::thread::errorproc ::thread::exit ::thread::id 
::thread::join ::thread::names ::thread::send ::thread::transfer 
::thread::wait}
+} $commands
 
 test thread-1.3 {ThreadObjCmd: initial thread list} {
     list [ThreadReap] [llength [thread::names]]

--
The TclCore mailing list is sponsored by Ajuba Solutions
To unsubscribe:  email tcl...@aj... with the 
                 word UNSUBSCRIBE as the subject.