From: Daniel A. S. <st...@ic...> - 2002-10-22 23:40:47
|
Don, On Wednesday, October 23, 2002, at 08:18 AM, Donald G Porter wrote: > The problem is the extending is happening in the wrong place. The > clean hook for extension is [package unknown]. In fact, that's > probably the right solution to our disagreement. Rather than > modifying [tclPkgUnknown] with more special cases, you should probably > write an entirely new [tcl::MacOSXPkgUnknown] and have init.tcl > call [package unknown] with it instead of [tclPkgUnknown] when it > detects initialization on the MacOSX platform. > > Yes, that's the right answer. That should make us all happy. In fact > we could apply the same technique to the "resource fork" special case > and clean that up at the same time. Good idea! I like that solution; had a stab at it, see the attached patch. Depending on platform, a different [package unknown] handler is installed in init.tcl (hadn't noticed your suggestion of tcl::MacOSXPkgUnknown before, but that's probably a better naming scheme than my tclMacOSXPkgUnknown resp. tclMacPkgUnknown) This is indeed much cleaner. Functionally this should not make any difference to what's now checked into 8.4.1, in effect it's just a code cleanup... Cheers, Daniel -- ** Daniel A. Steffen ** "And now to something completely ** Dept. of Mathematics ** different" Monty Python ** Macquarie University ** <mailto:st...@ma...> ** NSW 2109 Australia ** <http://www.maths.mq.edu.au/~steffen/> |