From: SourceForge.net <no...@so...> - 2012-12-09 12:09:21
|
Bugs item #3389251, was opened at 2011-08-09 14:38 Message generated for change (Comment added) made by ferrieux You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=110894&aid=3389251&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. >Category: 25. Channel System >Group: development: 8.6.0 >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: miguel sofer (msofer) >Assigned to: Alexandre Ferrieux (ferrieux) Summary: spurios output in 'make test' Initial Comment: Running 'make test' on today's trunk tip shows (look right after chan.test) Tests began at Tue Aug 09 18:35:22 ART 2011 append.test appendComp.test apply.test assemble.test assocd.test async.test autoMkindex.test basic.test binary.test case.test chan.test ' chanio.test clock.test ---------------------------------------------------------------------- >Comment By: Alexandre Ferrieux (ferrieux) Date: 2012-12-09 04:09 Message: Okay, just committed to 8.6 trunk (c6db0a87d1) what was really an unwanted side-effect from chan-4.6. Continuiing the discussion about close/exit/eofchar in 3389289. ---------------------------------------------------------------------- Comment By: Alexandre Ferrieux (ferrieux) Date: 2011-08-09 15:52 Message: Hm, strike that one, the problem is different. Opening new bug 3389289 to keep track of it. Let's come back here when that knot is untangled. ---------------------------------------------------------------------- Comment By: Alexandre Ferrieux (ferrieux) Date: 2011-08-09 15:19 Message: Ah, I've found the (old) bug that has been snuffing the eofchar for ages: 653218 "Channels CloseProc() not called on close" ---------------------------------------------------------------------- Comment By: Alexandre Ferrieux (ferrieux) Date: 2011-08-09 15:14 Message: Since it occurs only as a result of today's commit of full-finalize-on -DPURIFY, nobody has had yet a chance to fix it I guess... The problem is that the semantics of full finalization are in a grey area -- no specs :P Maybe we should work to bring back symmetry, so that even in a non-finalized case we get the same output; then we can fix the test. ---------------------------------------------------------------------- Comment By: miguel sofer (msofer) Date: 2011-08-09 15:09 Message: So is it a bug in the test itself? Is it reported, or is anybody fixing it already? ---------------------------------------------------------------------- Comment By: Alexandre Ferrieux (ferrieux) Date: 2011-08-09 15:06 Message: In 8.5, though Finalize was called, the closing of (std?) channels was not complete. You can observe the same behavior in 8.5 by adding [close stdout] at the end. So I'd say this is the correct behavior, bugs are behind us... ---------------------------------------------------------------------- Comment By: Alexandre Ferrieux (ferrieux) Date: 2011-08-09 14:44 Message: See comment about this in 2919042: it is test chan-4.6 which sets an output oefchar on stdout (the single quote). It turns out that full finalization (you used -DPURIFY, right ?) forces the output eofchar to be written. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=110894&aid=3389251&group_id=10894 |