From: Trevor D. (Twylite) <tw...@cr...> - 2012-11-24 11:35:14
|
Hi, On 2012/11/23 01:28 PM, Donal K. Fellows wrote: >>> although [upvar 2] occurs occasionally (meaning i used it once). >> [upvar 5] appears to be used in: >> tcllib/fileutil/multiop.tcl > I'm not saying that they don't occur. Just that they're really supremely > unwise or an indication of poor choice of refactoring points. ([upvar > 5]? There are really three controlled levels between the user's code and > the point where the library wants the variable? Isn't that excessively > baroque?) Indeed; mine was more a list of candidates for refactoring than reasons to hold up [upvar] optimisation. IIRC Snit method calls have one or two levels of Snit about them, so you need to [upvar 2] to find the actual caller, which seems to account for most of those occurrences. Regards, Twylite |