Menu
▾
▴
[Tcl-bugs] [ tktoolkit-Bugs-3566106 ] Tk 8.5.12 fails to build on Solaris 9/x86
|
From: SourceForge.net <no...@so...> - 2012-09-11 19:21:48
|
Bugs item #3566106, was opened at 2012-09-09 11:13 Message generated for change (Comment added) made by dkf You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=112997&aid=3566106&group_id=12997 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 84. Unix Build Group: current: 8.5.12 Status: Open Resolution: None Priority: 5 Private: No Submitted By: Roy Keene (rkeene) Assigned to: Donal K. Fellows (dkf) Summary: Tk 8.5.12 fails to build on Solaris 9/x86 Initial Comment: In working with the OpenCSW people about updating Tcl/Tk in OpenCSW (package distribution for Solaris) they ran into an issue with building Tk on Solaris 9/x86. They provided this patch: http://sourceforge.net/apps/trac/gar/browser/csw/mgar/pkg/tcl85/trunk/files/0002-Fix-linking-issues-and-enable-building-on-Solaris-9-.patch They indicate that "amd64" isn't part of the platform specification on Solaris 9 (Solaris 10+ only) and so the check should also include a check for "i386" only. Additionally there were some places where a single digit minor version wasn't checked for. ---------------------------------------------------------------------- >Comment By: Donal K. Fellows (dkf) Date: 2012-09-11 12:21 Message: This patch consists of 5 changes to tcl.m4. I'll comment on them in order: 1) Comment-only change. Meh. 2) This is probably critical; I'm guessing that the old version of the test never worked at all. It would be *really* nice to know what Solaris on amd64 actually reports of the architecture. But this change definitely does not make things worse. 3) I believe this change has no effect; the first part of the pattern subsumes the (added) second part of the pattern. 4) This might be important (it adds an extra flag, though I'm a little surprised that the dynamic linker needs a -L flag; could be necessary though, and if not it will be Mostly Harmless). 5) This might be important (it moves the flags set at change 4 to earlier in the command line; some linkers might need that). ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2012-09-11 07:01 Message: Patches committed on bug-3566106 for both Tcl and Tk. Review and merge requested. ---------------------------------------------------------------------- Comment By: Roy Keene (rkeene) Date: 2012-09-11 06:56 Message: This is only a problem for Tk (it may be coincidental though, since Tk relies on a different set of libraries for Solaris 9 and Solaris 10 but Tcl relies on the same set of libraries for Solaris 9 and Solaris 10). There was once a Tk release that did work correctly, but it may not have been Tk 8.5. It may have been many years since it was tested on Solaris 9. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2012-09-11 05:16 Message: Are these problems only for Tk, or does the tcl.m4 file in Tcl need revision too? Does this patch represent correcting a regression in Tcl? That is, was there once a Tcl release that did build on this system, and we made changes that broke that? Or does this patch make us support this system correctly for the first time? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=112997&aid=3566106&group_id=12997 |